Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to social icons. went away from sharrre library because libra… #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rudy-sasquatchstudio
Copy link
Contributor

…ry was outdated and not compatible with new versions of social network api’s. Twitter also no longer provides counter numbers the only way to do this is by using this library https://github.com/Julienh/Sharrre/blob/master/doc/twitter-counter.md which you would have to subscribe to on a site by site basis. Google share in sharrre also required you use a PHP script as well which didn’t seem to work that well when I integrated it.

…y was outdated and not compatible with new versions of social network api’s. Twitter also no longer provides counter numbers the only way to do this is by using this library https://github.com/Julienh/Sharrre/blob/master/doc/twitter-counter.md which you would have to subscribe to on a site by site basis.  Google share in sharrre also required you use a PHP script as well which didn’t seem to work that well when I integrated it.
@Mopok
Copy link
Contributor

Mopok commented Mar 7, 2017

@rudy-sasquatchstudio By any chance does this fix this:

screen shot 2017-03-06 at 5 49 36 pm

Notice icons for twitter and instagram are switched. I see this PR deletes the old images and adds some nice new ones. How would I retrieve these new ones? The old ones were just cut out of the image you removed like so:

`
.social-links .icon-facebook {
background: url("../images/social.png") 0 0;
}

.social-links .icon-instagram {
background: url("../images/social.png") 32px 0;
}

.social-links .icon-twitter {
background: url("../images/social.png") 16px 0;
}
`

So if you delete the images, maybe delete this code from style.css and add new code for each of the new icons? Or if there is another way to get the icons let me know!

@rudy-sasquatchstudio
Copy link
Contributor Author

Thanks Mark. I was pretty confused as to where those social icons were getting loaded to (the ones you are highlighting). I was thinking that those social icons were supposed to get loaded on the product page when you were reviewing an item.

screen shot 2017-03-07 at 10 56 06 pm

So there is no need then to remove the icon file that you highlighted in your comment. The rest of my pull-request I believe is still valid though as it is for the work that shows on all the product pages when you select an item. Let me know if you have anymore questions.

Copy link
Contributor

@aperdomo aperdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rudy-sasquatchstudio

Notes:

  • The counts for each social icon on the product page are lost on reloads
  • Count/icon alignment looks off
  • You'll need to resolve conflicts with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants