Skip to content

Commit

Permalink
Changes for new release
Browse files Browse the repository at this point in the history
  • Loading branch information
cecilios committed Dec 29, 2018
1 parent 9880af3 commit d185367
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 21 deletions.
40 changes: 32 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Lomse Library. Log of changes


[Since last version] 0.25.0
[Since last version] 0.26.0
=============================

##### BACKWARDS INCOMPATIBLE CHANGES WITH 0.25.0
Expand All @@ -10,6 +10,28 @@

##### COMPATIBLE CHANGES

- None.



Version [0.26.0] (29/Dec/2018)
=============================

##### BACKWARDS INCOMPATIBLE CHANGES WITH 0.25.0

- Pitch representation in Lomse internal model was not the best representation for
supporting transposition or other pitch changes. So, it was necessary to review and
change all this in the internal model. This change should not create backwards
incompatibilities in user applications, but it is an important change.

- External methods related to key signatures have been packaged as static methods in
a new class KeyUtilities. Probably, current applications using Lomse never used
these methods, so this change should not create backwards incompatibilities.

##### COMPATIBLE CHANGES

- Added new edition commands for transposition.
- Added class FIntval for managing intervals.
- MusicXML importer now accepts metronome directions.
- The algorithm for auto-scroll has been improved.
- During playback, when the time signature changes, metronome clicks
Expand All @@ -20,7 +42,7 @@
- Added Interactor method to customize visual tracking effects
- Added Interactor method to define what is a beat. This allows, for
example, to subdivide metronome or to decide which note duration
corresponds to a metronome click. It is also usefull for methods that
corresponds to a metronome click. It is also useful for methods that
specify a location by using measure/beat parameters.
- The internal model now has information about measure attributes, such
as the displayed measure number. All importers now parse and
Expand All @@ -33,7 +55,7 @@
- Defined a new barline type: alternative rendering for double repetition,
using two thick barlines instead of thin barlines (E.Gould, p.234)
- Fixes for removing Microsoft compiler warnings.
- Fixes for all high impact oustanding defects detected with coverity scan.
- Fixes for all high impact outstanding defects detected with coverity scan.
- Fixes for a few bugs causing a crash in specific scenarios:
- Visual tracking effects now cleared after deleting the graphic model.
- The sound thread is now not deleted when it has finished.
Expand All @@ -42,14 +64,14 @@
the next document page.
- Fixes for a few bugs related to scores layout:
- Fixed bug preventing to modify spacing value parameter from score
option "Render.SpacingValue". Also it was incorrectly trated as
option "Render.SpacingValue". Also it was incorrectly treated as
float in ScoreMeter and in LDP parser.
- Fixed bugs related to Gourlay's lines justification and value for Dmin
parameter.
- Spacing when there are invisible shapes (e.g. spacers) where
incorrectly computed
- A clef change after prolog was not engraved in smaller size because
it was considered part of the prolog.
it was considered part of the prolog.
- Fixed some bugs related to visual tracking effects:
- Color for highlight notes visual tracking was not initialized.
- Bug in tempo line positioning preventing to move the line to the correct page.
Expand All @@ -58,10 +80,11 @@
- Removed unused method `Interactor::move_tempo_line_to(ImoStaffobj* pSO)`.
- Incorrect computation of beat type (strong, weak, off-beat), that
affected to the computation of note volume, for stressing strong beats.
It also affected Lomse user applications that could be using this method, such as LenMus Phonascus.
It also affected Lomse user applications that could be using this method, such
as LenMus Phonascus.
- Spacing algorithm has been refactored to facilitate maintenance. All
spacing methods have been reviewed and more tests added. All test
has been documented as well as the reasons for the differente rules.
has been documented as well as the reasons for the different rules.
Fixes in a couple of spacing rules.


Expand Down Expand Up @@ -718,7 +741,8 @@ Version 0.10.b1
- Initial public release, used in Phonascus 5.0 beta for Linux.


[Since last version]: https://github.com/lenmus/lomse/compare/0.25.0...HEAD
[Since last version]: https://github.com/lenmus/lomse/compare/0.26.0...HEAD
[0.26.0]: https://github.com/lenmus/lomse/compare/0.25.0...0.26.0
[0.25.0]: https://github.com/lenmus/lomse/compare/0.24.0...0.25.0
[0.24.0]: https://github.com/lenmus/lomse/compare/0.23.0...0.24.0
[0.23.0]: https://github.com/lenmus/lomse/compare/0.22.0...0.23.0
Expand Down
2 changes: 1 addition & 1 deletion build-version.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#-------------------------------------------------------------------------------------

set( LOMSE_VERSION_MAJOR 0 )
set( LOMSE_VERSION_MINOR 25 )
set( LOMSE_VERSION_MINOR 26 )
set( LOMSE_VERSION_PATCH 0 )

# build version string for installer name
Expand Down
4 changes: 2 additions & 2 deletions debian/changelog
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
lomse (0.25.0) stable; urgency=low
lomse (0.26.0) stable; urgency=low

* Latest release

-- Cecilio Salmeron <[email protected]> Thu, 28 Jun 2018 19:18:39 +0200
-- Cecilio Salmeron <[email protected]> Sat, 29 Dec 2018 16:30:49 +0100

2 changes: 1 addition & 1 deletion docs/api/doxyfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

DOXYFILE_ENCODING = UTF-8
PROJECT_NAME = "Lomse library. API documentation"
PROJECT_NUMBER = 0.25.0
PROJECT_NUMBER = 0.26.0
PROJECT_BRIEF =
PROJECT_LOGO = ./images/logo_100x195.png
OUTPUT_DIRECTORY = ../../zz_build-api
Expand Down
17 changes: 8 additions & 9 deletions include/lomse_command.h
Original file line number Diff line number Diff line change
Expand Up @@ -2175,18 +2175,17 @@ class CmdTransposeDiatonically : public CmdTranspose
key signature symbol by the new key signature and transpose the affected notes,
chromatically, by the interval between the new key and the old key signatures.
Therefore, for transposing by key there is not necessary to use any special command.
The only need is a method to compute the interval between two key signatures. Class
KeyUtilities provides three methods for this:
Therefore, for transposing by key no special command is needed, just
CmdTransposeChromatically; and also a method to compute the interval between two key
signatures. Class KeyUtilities provides three methods for this:
KeyUtilities::up_interval()
KeyUtilities::down_interval()
KeyUtilities::closest_interval()
Commands CmdTransposeDiatonically and CmdTransposeChromatically, only deals with
user selected notes. But a command for transposing to a different key signature must
deal with notes and with keys, and how to deal with them is an application
behaviour decision that can not be generalized because there are many scenarios to
consider:
Take into account that a command for transposing to a different key signature can
not be a general basic command because it must deal with notes and with keys, and
how to deal with them is an application behaviour decision that can not be
generalized. There are many scenarios to consider:
- scores with key changes;
- transposing instruments with a different key;
- scope of the command: the command must affect to all the score? or only to a
Expand All @@ -2201,7 +2200,7 @@ class CmdTransposeDiatonically : public CmdTranspose
- insert the old key signature after the last transposed note,
- other.
Because all of these considerations and possible applicacion scenarios, Lomse can
Because all of these considerations and possible application scenarios, Lomse can
not provide a generic key transposition command. Nevertheless, for convenience, the
CmdTransposeKey command has been created to be used in simple cases.
Expand Down

0 comments on commit d185367

Please sign in to comment.