Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(internal/session): add more unit tests with smaller functions #359

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Feb 5, 2025

Signed-off-by: Gyuho Lee [email protected]

@gyuho gyuho self-assigned this Feb 5, 2025
@gyuho gyuho added this to the v0.4.0 milestone Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 81.69014% with 13 lines in your changes missing coverage. Please review.

Project coverage is 23.41%. Comparing base (f909795) to head (278c55d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/session/session.go 81.69% 10 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #359   +/-   ##
=======================================
  Coverage   23.41%   23.41%           
=======================================
  Files         287      287           
  Lines       25695    25707   +12     
=======================================
+ Hits         6016     6020    +4     
- Misses      19074    19081    +7     
- Partials      605      606    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gyuho gyuho modified the milestones: v0.4.0, v0.4.1 Feb 7, 2025
internal/session/session.go Outdated Show resolved Hide resolved
@gyuho gyuho removed this from the v0.4.1 milestone Feb 10, 2025
Copy link
Collaborator

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @cardyok PTAL

Copy link
Collaborator

@cardyok cardyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuho gyuho merged commit 67fd4f5 into main Feb 11, 2025
15 checks passed
@gyuho gyuho deleted the session-uts branch February 11, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants