Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd/gpud): clean up "gpud down" logs #41

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(cmd/gpud): clean up "gpud down" logs #41

merged 1 commit into from
Aug 28, 2024

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Aug 27, 2024

Before:

gpud down

 ✘ failed to stop systemd unit 'gpud.service': systemctl stop failed: exit status 5 output: Failed to stop gpud.service: Unit gpud.service not loaded.

gpud: systemctl stop failed: exit status 5 output: Failed to stop gpud.service: Unit gpud.service not loaded.

After:

gpud down

✔ gpud is not running (no-op)

@gyuho gyuho self-assigned this Aug 27, 2024
@gyuho gyuho added the enhancement make things better label Aug 27, 2024
hm2501
hm2501 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@hm2501 hm2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyuho gyuho merged commit 183b0fe into main Aug 28, 2024
5 checks passed
@gyuho gyuho deleted the gpu-down-clean branch August 28, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hm2501 hm2501 hm2501 approved these changes

Assignees

@gyuho gyuho

Labels
enhancement make things better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @hm2501