fix(nvidia): skip clock events NVML check if not supported by old drivers #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
changed the title
gyuho
force-pushed
the
skip-clock-events
branch
2 times, most recently
from
d16ee32 to
629b5a3
Compare
gyuho
changed the title
gyuho
changed the title
gyuho
changed the title
…vers Signed-off-by: Gyuho Lee <[email protected]>
gyuho
force-pushed
the
skip-clock-events
branch
from
5aedc5e to
65e00fd
Compare
hm2501
approved these changes
Sep 7, 2024
| // clock events are supported in versions 535 and above | ||
| // otherwise, CGO call just exits with | ||
| // undefined symbol: nvmlDeviceGetCurrentClocksEventReasons | ||
| func ClockEventsSupportedVersion(major, minor, patch int) bool { |
There was a problem hiding this comment.
do we need minor and patch params?
Signed-off-by: Gyuho Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @cardyok:
Not all NVIDIA drivers support this symbol. And if we don't do this, the CGO call just exits the whole process.
(ref. NVIDIA/go-nvml#123)