Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite on Pydantic #104

Merged
merged 8 commits into from
Nov 24, 2024
Merged

Rewrite on Pydantic #104

merged 8 commits into from
Nov 24, 2024

Conversation

shenanigansd
Copy link
Member

Closes #103, rewriting on top of Pydantic instead of dataclasses to avoid blowing up on spec changes.

This PR also includes some QoL changes:

  • Switching from the bespoke make.ps1 to Nox

Signed-off-by: GitHub <[email protected]>
@shenanigansd shenanigansd self-assigned this Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.04%. Comparing base (70ee6c1) to head (10d2f6e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/letsbuilda/pypi/async_client.py 0.00% 3 Missing ⚠️
src/letsbuilda/pypi/sync_client.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   77.35%   76.04%   -1.32%     
==========================================
  Files           8        8              
  Lines         212      167      -45     
==========================================
- Hits          164      127      -37     
+ Misses         48       40       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@shenanigansd shenanigansd marked this pull request as ready for review November 24, 2024 04:42
@shenanigansd shenanigansd merged commit 7103c8f into main Nov 24, 2024
13 checks passed
@shenanigansd shenanigansd deleted the br/gh103 branch November 24, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to Pydantic
1 participant