Bring back lfc #121

erlingrj · 2024-11-14T04:41:17Z

This adds back LFC support ontop of our nice macro system. Next step is to support federated programs written in LFC.

Also adds:

TriggerObservers/sources
Triggered by contained outpts
Writing to contained inputs

The code-gen is still very messy and has to be improved. But I think we should merge this in and improve the code generator separatly

github-actions · 2024-11-14T04:42:23Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to
text	59581	59581
data	744	744
bss	480	480
total	60805	60805

action_microstep_test_c

	from	to
text	60402	60402
data	752	752
bss	480	480
total	61634	61634

action_overwrite_test_c

	from	to
text	60249	60249
data	744	744
bss	480	480
total	61473	61473

action_test_c

	from	to
text	60157	60157
data	752	752
bss	480	480
total	61389	61389

delayed_conn_test_c

	from	to
text	59503	59503
data	744	744
bss	480	480
total	60727	60727

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to
text	56656	56656
data	744	744
bss	11904	11904
total	69304	69304

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to
text	60776	60776
data	769	769
bss	10240	10240
total	71785	71785

port_test_c

	from	to
text	59451	59451
data	744	744
bss	480	480
total	60675	60675

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to
text	60354	60354
data	744	744
bss	480	480
total	61578	61578

shutdown_test_c

	from	to
text	56441	56441
data	744	744
bss	10944	10944
total	68129	68129

startup_test_c

	from	to
text	55764	55764
data	752	752
bss	10688	10688
total	67204	67204

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to
text	55664	55664
data	744	744
bss	10720	10720
total	67128	67128

github-actions · 2024-11-14T22:42:20Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to
text	59581	59581
data	744	744
bss	480	480
total	60805	60805

action_microstep_test_c

	from	to
text	60402	60402
data	752	752
bss	480	480
total	61634	61634

action_overwrite_test_c

	from	to
text	60249	60249
data	744	744
bss	480	480
total	61473	61473

action_test_c

	from	to
text	60157	60157
data	752	752
bss	480	480
total	61389	61389

delayed_conn_test_c

	from	to
text	59503	59503
data	744	744
bss	480	480
total	60727	60727

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to
text	56656	56656
data	744	744
bss	11904	11904
total	69304	69304

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to
text	60776	60776
data	769	769
bss	10240	10240
total	71785	71785

port_test_c

	from	to
text	59451	59451
data	744	744
bss	480	480
total	60675	60675

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to
text	60354	60354
data	744	744
bss	480	480
total	61578	61578

shutdown_test_c

	from	to
text	56441	56441
data	744	744
bss	10944	10944
total	68129	68129

startup_test_c

	from	to
text	55764	55764
data	752	752
bss	10688	10688
total	67204	67204

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to
text	55664	55664
data	744	744
bss	10720	10720
total	67128	67128

github-actions · 2024-11-15T01:15:27Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to	increase (%)
text	59581	59450	-0.22
data	744	744	0.00
bss	480	480	0.00
total	60805	60674	-0.22

action_microstep_test_c

	from	to	increase (%)
text	60402	60271	-0.22
data	752	752	0.00
bss	480	480	0.00
total	61634	61503	-0.21

action_overwrite_test_c

	from	to	increase (%)
text	60249	60118	-0.22
data	744	744	0.00
bss	480	480	0.00
total	61473	61342	-0.21

action_test_c

	from	to	increase (%)
text	60157	60026	-0.22
data	752	752	0.00
bss	480	480	0.00
total	61389	61258	-0.21

delayed_conn_test_c

	from	to	increase (%)
text	59503	59372	-0.22
data	744	744	0.00
bss	480	480	0.00
total	60727	60596	-0.22

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to	increase (%)
text	56656	56525	-0.23
data	744	744	0.00
bss	11904	11904	0.00
total	69304	69173	-0.19

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to	increase (%)
text	60776	60645	-0.22
data	769	769	0.00
bss	10240	10240	0.00
total	71785	71654	-0.18

port_test_c

	from	to	increase (%)
text	59451	59320	-0.22
data	744	744	0.00
bss	480	480	0.00
total	60675	60544	-0.22

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to	increase (%)
text	60354	60223	-0.22
data	744	744	0.00
bss	480	480	0.00
total	61578	61447	-0.21

shutdown_test_c

	from	to	increase (%)
text	56441	56310	-0.23
data	744	744	0.00
bss	10944	10944	0.00
total	68129	67998	-0.19

startup_test_c

	from	to	increase (%)
text	55764	55633	-0.23
data	752	752	0.00
bss	10688	10688	0.00
total	67204	67073	-0.19

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to	increase (%)
text	55664	55533	-0.24
data	744	744	0.00
bss	10720	10720	0.00
total	67128	66997	-0.20

github-actions · 2024-11-15T01:20:37Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to	increase (%)
text	59581	59450	-0.22
data	744	744	0.00
bss	480	480	0.00
total	60805	60674	-0.22

action_microstep_test_c

	from	to	increase (%)
text	60402	60271	-0.22
data	752	752	0.00
bss	480	480	0.00
total	61634	61503	-0.21

action_overwrite_test_c

	from	to	increase (%)
text	60249	60118	-0.22
data	744	744	0.00
bss	480	480	0.00
total	61473	61342	-0.21

action_test_c

	from	to	increase (%)
text	60157	60026	-0.22
data	752	752	0.00
bss	480	480	0.00
total	61389	61258	-0.21

delayed_conn_test_c

	from	to	increase (%)
text	59503	59372	-0.22
data	744	744	0.00
bss	480	480	0.00
total	60727	60596	-0.22

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to	increase (%)
text	56656	56525	-0.23
data	744	744	0.00
bss	11904	11904	0.00
total	69304	69173	-0.19

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to	increase (%)
text	60776	60645	-0.22
data	769	769	0.00
bss	10240	10240	0.00
total	71785	71654	-0.18

port_test_c

	from	to	increase (%)
text	59451	59320	-0.22
data	744	744	0.00
bss	480	480	0.00
total	60675	60544	-0.22

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to	increase (%)
text	60354	60223	-0.22
data	744	744	0.00
bss	480	480	0.00
total	61578	61447	-0.21

shutdown_test_c

	from	to	increase (%)
text	56441	56310	-0.23
data	744	744	0.00
bss	10944	10944	0.00
total	68129	67998	-0.19

startup_test_c

	from	to	increase (%)
text	55764	55633	-0.23
data	752	752	0.00
bss	10688	10688	0.00
total	67204	67073	-0.19

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to	increase (%)
text	55664	55533	-0.24
data	744	744	0.00
bss	10720	10720	0.00
total	67128	66997	-0.20

github-actions · 2024-11-16T02:20:27Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to	increase (%)
text	59581	59772	0.32
data	744	744	0.00
bss	480	480	0.00
total	60805	60996	0.31

action_microstep_test_c

	from	to	increase (%)
text	60402	60607	0.34
data	752	752	0.00
bss	480	480	0.00
total	61634	61839	0.33

action_overwrite_test_c

	from	to	increase (%)
text	60249	60454	0.34
data	744	744	0.00
bss	480	480	0.00
total	61473	61678	0.33

action_test_c

	from	to	increase (%)
text	60157	60362	0.34
data	752	752	0.00
bss	480	480	0.00
total	61389	61594	0.33

delayed_conn_test_c

	from	to	increase (%)
text	59503	59880	0.63
data	744	744	0.00
bss	480	480	0.00
total	60727	61104	0.62

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to	increase (%)
text	56656	56791	0.24
data	744	744	0.00
bss	11904	12032	1.08
total	69304	69567	0.38

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to	increase (%)
text	60776	60983	0.34
data	769	769	0.00
bss	10240	10240	0.00
total	71785	71992	0.29

port_test_c

	from	to	increase (%)
text	59451	59828	0.63
data	744	744	0.00
bss	480	480	0.00
total	60675	61052	0.62

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to	increase (%)
text	60354	60559	0.34
data	744	744	0.00
bss	480	480	0.00
total	61578	61783	0.33

shutdown_test_c

	from	to	increase (%)
text	56441	56576	0.24
data	744	744	0.00
bss	10944	11008	0.58
total	68129	68328	0.29

startup_test_c

	from	to	increase (%)
text	55764	55872	0.19
data	752	752	0.00
bss	10688	10720	0.30
total	67204	67344	0.21

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to	increase (%)
text	55664	55756	0.17
data	744	744	0.00
bss	10720	10720	0.00
total	67128	67220	0.14

github-actions · 2024-11-16T02:21:39Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to	increase (%)
text	59581	59772	0.32
data	744	744	0.00
bss	480	480	0.00
total	60805	60996	0.31

action_microstep_test_c

	from	to	increase (%)
text	60402	60607	0.34
data	752	752	0.00
bss	480	480	0.00
total	61634	61839	0.33

action_overwrite_test_c

	from	to	increase (%)
text	60249	60454	0.34
data	744	744	0.00
bss	480	480	0.00
total	61473	61678	0.33

action_test_c

	from	to	increase (%)
text	60157	60362	0.34
data	752	752	0.00
bss	480	480	0.00
total	61389	61594	0.33

delayed_conn_test_c

	from	to	increase (%)
text	59503	59880	0.63
data	744	744	0.00
bss	480	480	0.00
total	60727	61104	0.62

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to	increase (%)
text	56656	56791	0.24
data	744	744	0.00
bss	11904	12032	1.08
total	69304	69567	0.38

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to	increase (%)
text	60776	60983	0.34
data	769	769	0.00
bss	10240	10240	0.00
total	71785	71992	0.29

port_test_c

	from	to	increase (%)
text	59451	59828	0.63
data	744	744	0.00
bss	480	480	0.00
total	60675	61052	0.62

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to	increase (%)
text	60354	60559	0.34
data	744	744	0.00
bss	480	480	0.00
total	61578	61783	0.33

shutdown_test_c

	from	to	increase (%)
text	56441	56576	0.24
data	744	744	0.00
bss	10944	11008	0.58
total	68129	68328	0.29

startup_test_c

	from	to	increase (%)
text	55764	55872	0.19
data	752	752	0.00
bss	10688	10720	0.30
total	67204	67344	0.21

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to	increase (%)
text	55664	55756	0.17
data	744	744	0.00
bss	10720	10720	0.00
total	67128	67220	0.14

github-actions · 2024-11-16T02:31:45Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to	increase (%)
text	59581	59772	0.32
data	744	744	0.00
bss	480	480	0.00
total	60805	60996	0.31

action_microstep_test_c

	from	to	increase (%)
text	60402	60607	0.34
data	752	752	0.00
bss	480	480	0.00
total	61634	61839	0.33

action_overwrite_test_c

	from	to	increase (%)
text	60249	60454	0.34
data	744	744	0.00
bss	480	480	0.00
total	61473	61678	0.33

action_test_c

	from	to	increase (%)
text	60157	60362	0.34
data	752	752	0.00
bss	480	480	0.00
total	61389	61594	0.33

delayed_conn_test_c

	from	to	increase (%)
text	59503	59880	0.63
data	744	744	0.00
bss	480	480	0.00
total	60727	61104	0.62

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to	increase (%)
text	56656	56791	0.24
data	744	744	0.00
bss	11904	12032	1.08
total	69304	69567	0.38

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to	increase (%)
text	60776	60983	0.34
data	769	769	0.00
bss	10240	10240	0.00
total	71785	71992	0.29

port_test_c

	from	to	increase (%)
text	59451	59828	0.63
data	744	744	0.00
bss	480	480	0.00
total	60675	61052	0.62

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to	increase (%)
text	60354	60559	0.34
data	744	744	0.00
bss	480	480	0.00
total	61578	61783	0.33

shutdown_test_c

	from	to	increase (%)
text	56441	56576	0.24
data	744	744	0.00
bss	10944	11008	0.58
total	68129	68328	0.29

startup_test_c

	from	to	increase (%)
text	55764	55872	0.19
data	752	752	0.00
bss	10688	10720	0.30
total	67204	67344	0.21

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to	increase (%)
text	55664	55756	0.17
data	744	744	0.00
bss	10720	10720	0.00
total	67128	67220	0.14

erlingrj · 2024-11-16T02:32:21Z

CMakeLists.txt

@@ -80,6 +80,7 @@ if(NETWORK_CHANNEL_TCP_POSIX)
 endif()

 target_compile_options(reactor-uc PRIVATE -Wall -Wextra -Werror)
+target_compile_options(reactor-uc PUBLIC -Wno-zero-length-bounds)


Needed because our macros generate zero-length arrays

github-actions · 2024-11-16T02:32:28Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to	increase (%)
text	59581	59772	0.32
data	744	744	0.00
bss	480	480	0.00
total	60805	60996	0.31

action_microstep_test_c

	from	to	increase (%)
text	60402	60607	0.34
data	752	752	0.00
bss	480	480	0.00
total	61634	61839	0.33

action_overwrite_test_c

	from	to	increase (%)
text	60249	60454	0.34
data	744	744	0.00
bss	480	480	0.00
total	61473	61678	0.33

action_test_c

	from	to	increase (%)
text	60157	60362	0.34
data	752	752	0.00
bss	480	480	0.00
total	61389	61594	0.33

delayed_conn_test_c

	from	to	increase (%)
text	59503	59880	0.63
data	744	744	0.00
bss	480	480	0.00
total	60727	61104	0.62

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to	increase (%)
text	56656	56791	0.24
data	744	744	0.00
bss	11904	12032	1.08
total	69304	69567	0.38

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to	increase (%)
text	60776	60983	0.34
data	769	769	0.00
bss	10240	10240	0.00
total	71785	71992	0.29

port_test_c

	from	to	increase (%)
text	59451	59828	0.63
data	744	744	0.00
bss	480	480	0.00
total	60675	61052	0.62

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to	increase (%)
text	60354	60559	0.34
data	744	744	0.00
bss	480	480	0.00
total	61578	61783	0.33

shutdown_test_c

	from	to	increase (%)
text	56441	56576	0.24
data	744	744	0.00
bss	10944	11008	0.58
total	68129	68328	0.29

startup_test_c

	from	to	increase (%)
text	55764	55872	0.19
data	752	752	0.00
bss	10688	10720	0.30
total	67204	67344	0.21

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to	increase (%)
text	55664	55756	0.17
data	744	744	0.00
bss	10720	10720	0.00
total	67128	67220	0.14

erlingrj · 2024-11-16T02:34:29Z

include/reactor-uc/macros.h

+// FIXME: Separate user-facing vs internal macros
+// FIXME: Group macros either by functionality or by element they operate on


These will be addressed in later fixup PRs

erlingrj · 2024-11-16T02:36:06Z

include/reactor-uc/macros.h

-
-#define DEFINE_DELAYED_CONNECTION_STRUCT(ParentName, ReactorName, OutputPort, DownstreamSize, BufferType, BufferSize,  \
-                                         Delay)                                                                        \
+#define CONTAINED_OUTPUT_CONNECTIONS(ReactorName, OutputPort, NumConnsOut)                                             \


The following macros create the fields on the parents self the child ports.

erlingrj · 2024-11-16T02:36:53Z

include/reactor-uc/macros.h

+#define CONTAINED_OUTPUT_OBSERVERS(ReactorName, OutputPort, NumObservers)                                              \
+  Reaction *_observers_##ReactorName##_##OutputPort[NumObservers];
+
+#define DEFINE_CONTAINED_OUTPUT_ARGS(ReactorName, OutputPort)                                                          \


This macro creates an OutputExternalCtorArgs object and initializes its fields so that we can later pass it to the ctor of the child

erlingrj · 2024-11-16T02:37:25Z

include/reactor-uc/port.h

@@ -6,38 +6,45 @@
 #include "reactor-uc/reactor.h"
 #include "reactor-uc/trigger.h"

-typedef struct Input Input;


No longer any useful separation between Inputs and Outputs

erlingrj · 2024-11-16T02:38:30Z

lfc/core/src/main/kotlin/org/lflang/generator/uc/UcActionGenerator.kt

-
-    val Action.codeType
-        get(): String = "${reactor.name}_Action_$name"
-
    val Action.bufSize
        get(): Int = 12 // FIXME: This is a parameter/annotation


We need LF syntax to set this

github-actions · 2024-11-16T02:49:55Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to	increase (%)
text	59581	59772	0.32
data	744	744	0.00
bss	480	480	0.00
total	60805	60996	0.31

action_microstep_test_c

	from	to	increase (%)
text	60402	60607	0.34
data	752	752	0.00
bss	480	480	0.00
total	61634	61839	0.33

action_overwrite_test_c

	from	to	increase (%)
text	60249	60454	0.34
data	744	744	0.00
bss	480	480	0.00
total	61473	61678	0.33

action_test_c

	from	to	increase (%)
text	60157	60362	0.34
data	752	752	0.00
bss	480	480	0.00
total	61389	61594	0.33

delayed_conn_test_c

	from	to	increase (%)
text	59503	59880	0.63
data	744	744	0.00
bss	480	480	0.00
total	60727	61104	0.62

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to	increase (%)
text	56656	56791	0.24
data	744	744	0.00
bss	11904	12032	1.08
total	69304	69567	0.38

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to	increase (%)
text	60776	60983	0.34
data	769	769	0.00
bss	10240	10240	0.00
total	71785	71992	0.29

port_test_c

	from	to	increase (%)
text	59451	59828	0.63
data	744	744	0.00
bss	480	480	0.00
total	60675	61052	0.62

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to	increase (%)
text	60354	60559	0.34
data	744	744	0.00
bss	480	480	0.00
total	61578	61783	0.33

shutdown_test_c

	from	to	increase (%)
text	56441	56576	0.24
data	744	744	0.00
bss	10944	11008	0.58
total	68129	68328	0.29

startup_test_c

	from	to	increase (%)
text	55764	55872	0.19
data	752	752	0.00
bss	10688	10720	0.30
total	67204	67344	0.21

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to	increase (%)
text	55664	55756	0.17
data	744	744	0.00
bss	10720	10720	0.00
total	67128	67220	0.14

github-actions · 2024-11-16T08:14:22Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to	increase (%)
text	59581	59772	0.32
data	744	744	0.00
bss	480	480	0.00
total	60805	60996	0.31

action_microstep_test_c

	from	to	increase (%)
text	60402	60607	0.34
data	752	752	0.00
bss	480	480	0.00
total	61634	61839	0.33

action_overwrite_test_c

	from	to	increase (%)
text	60249	60454	0.34
data	744	744	0.00
bss	480	480	0.00
total	61473	61678	0.33

action_test_c

	from	to	increase (%)
text	60157	60362	0.34
data	752	752	0.00
bss	480	480	0.00
total	61389	61594	0.33

delayed_conn_test_c

	from	to	increase (%)
text	59503	59880	0.63
data	744	744	0.00
bss	480	480	0.00
total	60727	61104	0.62

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to	increase (%)
text	56656	56791	0.24
data	744	744	0.00
bss	11904	12032	1.08
total	69304	69567	0.38

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to	increase (%)
text	60776	60983	0.34
data	769	769	0.00
bss	10240	10240	0.00
total	71785	71992	0.29

port_test_c

	from	to	increase (%)
text	59451	59828	0.63
data	744	744	0.00
bss	480	480	0.00
total	60675	61052	0.62

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to	increase (%)
text	60354	60559	0.34
data	744	744	0.00
bss	480	480	0.00
total	61578	61783	0.33

shutdown_test_c

	from	to	increase (%)
text	56441	56576	0.24
data	744	744	0.00
bss	10944	11008	0.58
total	68129	68328	0.29

startup_test_c

	from	to	increase (%)
text	55764	55872	0.19
data	752	752	0.00
bss	10688	10720	0.30
total	67204	67344	0.21

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to	increase (%)
text	55664	55756	0.17
data	744	744	0.00
bss	10720	10720	0.00
total	67128	67220	0.14

github-actions · 2024-11-16T18:55:12Z

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

	from	to	increase (%)
text	59581	59772	0.32
data	744	744	0.00
bss	480	480	0.00
total	60805	60996	0.31

action_microstep_test_c

	from	to	increase (%)
text	60402	60607	0.34
data	752	752	0.00
bss	480	480	0.00
total	61634	61839	0.33

action_overwrite_test_c

	from	to	increase (%)
text	60249	60454	0.34
data	744	744	0.00
bss	480	480	0.00
total	61473	61678	0.33

action_test_c

	from	to	increase (%)
text	60157	60362	0.34
data	752	752	0.00
bss	480	480	0.00
total	61389	61594	0.33

delayed_conn_test_c

	from	to	increase (%)
text	59503	59880	0.63
data	744	744	0.00
bss	480	480	0.00
total	60727	61104	0.62

event_payload_pool_test_c

	from	to
text	18330	18330
data	624	624
bss	320	320
total	19274	19274

event_queue_test_c

	from	to
text	27439	27439
data	728	728
bss	480	480
total	28647	28647

multiple_startup_shutdown_test_c

	from	to	increase (%)
text	56656	56791	0.24
data	744	744	0.00
bss	11904	12032	1.08
total	69304	69567	0.38

nanopb_test_c

	from	to
text	42888	42888
data	904	904
bss	320	320
total	44112	44112

physical_action_test_c

	from	to	increase (%)
text	60776	60983	0.34
data	769	769	0.00
bss	10240	10240	0.00
total	71785	71992	0.29

port_test_c

	from	to	increase (%)
text	59451	59828	0.63
data	744	744	0.00
bss	480	480	0.00
total	60675	61052	0.62

reaction_queue_test_c

	from	to
text	27151	27151
data	728	728
bss	480	480
total	28359	28359

request_shutdown_test_c

	from	to	increase (%)
text	60354	60559	0.34
data	744	744	0.00
bss	480	480	0.00
total	61578	61783	0.33

shutdown_test_c

	from	to	increase (%)
text	56441	56576	0.24
data	744	744	0.00
bss	10944	11008	0.58
total	68129	68328	0.29

startup_test_c

	from	to	increase (%)
text	55764	55872	0.19
data	752	752	0.00
bss	10688	10720	0.30
total	67204	67344	0.21

tcp_channel_test_c

	from	to
text	60281	60281
data	1176	1176
bss	11136	11136
total	72593	72593

timer_test_c

	from	to	increase (%)
text	55664	55756	0.17
data	744	744	0.00
bss	10720	10720	0.00
total	67128	67220	0.14

erlingrj · 2024-11-22T04:44:53Z

@tanneberger

github-actions · 2024-11-22T04:55:26Z

Coverage after merging bring-back-lfc into main will be

67.77%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
action.c	81.90%	69.23%	100%	85.33%	120–121, 24, 43–46, 49, 51, 53, 56–58, 63–64, 73–74, 85–86
builtin_triggers.c	90.91%	70%	100%	96.77%	14, 18, 40, 43
connection.c	78.52%	51.16%	100%	88.66%	10, 104, 11, 110, 123–124, 136–137, 14, 14, 143, 145, 16–17, 21–22, 22, 22–23, 25, 27–28, 33, 48, 48, 48–49, 55, 60–62, 97
environment.c	78.72%	56.25%	84.62%	83.08%	12–13, 18, 20–21, 35–36, 42–43, 51–52, 55–56, 60–61, 92–94
event.c	95.35%	92.86%	100%	96.15%	14–15
federated.c	0%	0%	0%	0%	10, 101–104, 106, 106, 106–109, 111, 113–114, 114, 114, 114–118, 12, 120–121, 124, 127–128, 128, 128–129, 131–132, 134, 138–139, 14, 14, 14, 141–143, 146, 148–149, 15, 150–153, 155–157, 16, 160–162, 162, 162–163, 163, 163–165, 167, 17, 170–171, 173–177, 179, 18, 180–184, 186, 186, 186–189, 19, 19, 19, 191, 191, 191–193, 193, 193–194, 198–199, 199, 199, 20, 202–203, 207–209, 211, 211, 211, 213–217, 220, 220, 220–223, 226–227, 227, 227–228, 23, 230–231, 234–235, 24, 240–241, 241, 241–242, 244, 246, 246, 246–249, 249, 249, 249, 249, 25, 25, 25, 250–259, 26, 260–261, 265, 268, 268, 268–269, 27, 27, 27, 270, 274, 277–278, 278, 278, 278–279, 28, 280–286, 288, 29, 290–292, 292, 292–293, 295, 295, 295–297, 299, 30, 30, 30, 300–301, 303, 305, 309, 309, 309, 31, 310, 310, 310–311, 311, 311–319, 32, 32, 32, 32, 320–322, 324–325, 328–329, 33, 330–331, 333, 333, 333–334, 338–339, 339, 339, 34, 341, 343–344, 344, 344–345, 345, 345–346, 346, 346–347, 347, 347–348, 348, 348–349, 349, 349, 35, 351, 351, 351–352, 352, 352–353, 353, 353–354, 354, 354, 356, 36–37, 39, 39, 39, 39, 39–40, 42–45, 50, 50, 50, 50, 50–51, 54, 58–59, 61–64, 66, 66, 66–67, 67, 67, 69, 69, 69–71, 71, 71–73, 77–78, 82–83, 85–88, 9, 90, 92, 92, 92–93, 93, 93–94, 94, 94–95, 95, 95, 98–99
logging.c	73.21%	60%	100%	75%	24, 24–27, 37–39, 46, 46–49, 59–60
port.c	81.43%	50%	100%	95.45%	10, 10, 10, 16, 20, 26, 26–28, 38, 38, 38–39
queues.c	89.94%	80.36%	100%	94.06%	107, 112, 118, 21–23, 46–47, 59–60, 83–87, 90–91
reaction.c	70.69%	54.55%	100%	79.10%	15, 17, 21, 28–31, 31, 31–32, 42, 45, 47, 52–53, 53, 53–55, 55, 55–56, 73, 89–91, 91, 91–94, 94, 94–95
reactor.c	69.33%	51.52%	100%	82.28%	10, 101–102, 14–19, 22, 28, 30, 32–37, 37, 37–38, 38, 38, 43, 55, 58–59, 59, 59–60, 60, 60–61, 63, 77–78, 81–82, 82, 82–83, 83, 83–84, 86, 91
serialization.c	50%	50%	50%	50%	16–17, 26–27, 33–35, 38–40
tag.c	40.19%	31.48%	60%	47.92%	14, 14–15, 17, 17–18, 23–24, 24, 24, 24, 24–25, 27, 27, 27, 27, 27–28, 30, 30, 30–31, 33–34, 34, 34–35, 37, 37, 37, 37, 37–38, 40, 40, 40, 40, 40–41, 43, 53–54, 63, 63–64, 83–85, 85, 85, 85, 85, 85, 85, 85, 85, 85, 85–87, 89
timer.c	95%	66.67%	100%	100%	14, 25
trigger.c	100%	100%	100%	100%
util.c	0%	0%	0%	0%	10, 3–4, 4, 4–5, 5, 5–6, 8–9
src/platform/posix
posix.c	52.73%	30%	66.67%	56%	100, 100, 100–102, 106, 16, 18, 20–21, 34–36, 38–40, 48–49, 54–59, 59, 59–62, 62, 62–64, 67, 73–74, 78, 81, 92–94, 94, 94–96, 98–99
tcp_ip_channel.c	67.44%	56.69%	94.12%	70.63%	114–116, 121–123, 127–129, 149, 153, 153, 153, 157–158, 171–172, 175–176, 178, 178, 178, 180–181, 183–184, 191–192, 194, 197, 212–213, 217–219, 221, 226–229, 232, 235, 238, 245–248, 250, 250, 250–252, 254–257, 260–261, 291–293, 300, 305–307, 307, 307–308, 310–313, 32, 322, 322–324, 33, 346–349, 349, 349–351, 361–362, 362, 362–363, 363, 363–364, 368–369, 372, 382–383, 400–401, 405–406, 41–42, 420,

erlingrj added 3 commits November 13, 2024 20:38

Bring code generator back from the dead

1c83839

Formatting

46d48b1

Add LF tests back to the CI

beb7051

erlingrj added 2 commits November 14, 2024 14:34

Fix up connection handling and add another test

72d4114

Fix some examples

cfa6393

Support more tests

2c1d621

Formatting

56c29a0

erlingrj added 3 commits November 15, 2024 16:32

Add the notion of an TriggerObserver and update macros and all tests

dc1c8f6

More LF smoke tests

3f57bca

Remove unused

d056c99

erlingrj added 2 commits November 15, 2024 18:30

Add a simple example of how to us LF with zephyr.

0413fbb

Run formatter

14a3afa

erlingrj commented Nov 16, 2024

View reviewed changes

Add some FIXMEs to the actiongenerator

66572aa

erlingrj requested a review from tanneberger November 16, 2024 02:48

LFC cleanup

db219b7

Rename CONTAINED_ to CHILD_

f1b82fc

erlingrj added 10 commits November 19, 2024 16:52

Port examples to new macro API supporting banks and multiports

b8e5dc7

Banks and multiports

1ec5e4f

Formatting

f0bff50

Stash

54d9a2a

Solve multiport and bank headache

71e7bd5

Merge remote-tracking branch 'origin/main' into bring-back-lfc

35e10a3

Small merge fixes

bbabcda

Improve docs on UcConnectionGenerator

b1457f7

Add fresh flag to cmake

d017148

Format

86caae7

Add a test of import

6b134d9

erlingrj merged commit 0f823af into main Nov 25, 2024
5 of 6 checks passed

erlingrj deleted the bring-back-lfc branch December 13, 2024 01:37

		// FIXME: Separate user-facing vs internal macros
		// FIXME: Group macros either by functionality or by element they operate on

Bring back lfc #121

Bring back lfc #121

Conversation

erlingrj commented Nov 14, 2024 • edited Loading

github-actions bot commented Nov 14, 2024

action_empty_test_c

action_microstep_test_c

action_overwrite_test_c

action_test_c

delayed_conn_test_c

event_payload_pool_test_c

event_queue_test_c

multiple_startup_shutdown_test_c

nanopb_test_c

physical_action_test_c

port_test_c

reaction_queue_test_c

request_shutdown_test_c

shutdown_test_c

startup_test_c

tcp_channel_test_c

timer_test_c

github-actions bot commented Nov 14, 2024

action_empty_test_c

action_microstep_test_c

action_overwrite_test_c

action_test_c

delayed_conn_test_c

event_payload_pool_test_c

event_queue_test_c

multiple_startup_shutdown_test_c

nanopb_test_c

physical_action_test_c

port_test_c

reaction_queue_test_c

request_shutdown_test_c

shutdown_test_c

startup_test_c

tcp_channel_test_c

timer_test_c

github-actions bot commented Nov 15, 2024

action_empty_test_c

action_microstep_test_c

action_overwrite_test_c

action_test_c

delayed_conn_test_c

event_payload_pool_test_c

event_queue_test_c

multiple_startup_shutdown_test_c

nanopb_test_c

physical_action_test_c

port_test_c

reaction_queue_test_c

request_shutdown_test_c

shutdown_test_c

startup_test_c

tcp_channel_test_c

timer_test_c

github-actions bot commented Nov 15, 2024

action_empty_test_c

action_microstep_test_c

action_overwrite_test_c

action_test_c

delayed_conn_test_c

event_payload_pool_test_c

event_queue_test_c

multiple_startup_shutdown_test_c

nanopb_test_c

physical_action_test_c

port_test_c

reaction_queue_test_c

request_shutdown_test_c

shutdown_test_c

startup_test_c

tcp_channel_test_c

timer_test_c

github-actions bot commented Nov 16, 2024

action_empty_test_c

action_microstep_test_c

action_overwrite_test_c

erlingrj commented Nov 14, 2024 •

edited

Loading