-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding basic unit tests #24
Conversation
It is related to #13. Suggestion: |
Sounds good to me! Let's merge this PR cnce we're done with these .rs files, |
0e0c45a
to
e83c3d8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@the-systematic-chaos Are you implementing and uploading the remaining unit test cases (TCs) of tag.rs within a few days? Before I add commits for unit TCs of sources from up-to-down directions in the above code coverage graph soon, I'll wait for you to finish your first commit. |
Hi Dr. Lee, yes I think I will be able to get it done in a few days. I am progressing with the test cases. |
This comment was marked as outdated.
This comment was marked as outdated.
b6eb6e0
to
35c8f14
Compare
It is necessary to rebase the main branch to enable CI After #42. |
62b1d6a
to
04e809f
Compare
@the-systematic-chaos Great to update unit tests of tag.rs! Let me submit a PR to resolve current conflicts in some files. |
c5a9161
to
e949c55
Compare
- 17 unit test cases are added.
- 22 TCs are added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We'd better make another PR for the remaining unit TC implementation.
No description provided.