Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic unit tests #24

Merged
merged 10 commits into from
Mar 15, 2024
Merged

Adding basic unit tests #24

merged 10 commits into from
Mar 15, 2024

Conversation

hokeun
Copy link
Member

@hokeun hokeun commented Jan 26, 2024

No description provided.

@chanijjani
Copy link
Collaborator

chanijjani commented Jan 30, 2024

It is related to #13.

Suggestion:
How about completing easier unit tests of sources (federate_info.rs / lib.rs / net_common.rs / rti_remote.rs / tag.rs) in this PR?

@hokeun
Copy link
Member Author

hokeun commented Jan 30, 2024

It is related to #13.

Suggestion: How about completing easier unit tests of sources (federate_info.rs / lib.rs / net_common.rs / rti_remote.rs / tag.rs) in this PR?

Sounds good to me! Let's merge this PR cnce we're done with these .rs files,

@chanijjani chanijjani force-pushed the unit_test branch 2 times, most recently from 0e0c45a to e83c3d8 Compare January 31, 2024 00:03
@chanijjani

This comment was marked as outdated.

@chanijjani
Copy link
Collaborator

@the-systematic-chaos Are you implementing and uploading the remaining unit test cases (TCs) of tag.rs within a few days? Before I add commits for unit TCs of sources from up-to-down directions in the above code coverage graph soon, I'll wait for you to finish your first commit.

@the-systematic-chaos
Copy link
Collaborator

@chanijjani

Hi Dr. Lee, yes I think I will be able to get it done in a few days. I am progressing with the test cases.

@chanijjani

This comment was marked as outdated.

@chanijjani chanijjani mentioned this pull request Feb 11, 2024
11 tasks
@chanijjani chanijjani force-pushed the unit_test branch 6 times, most recently from b6eb6e0 to 35c8f14 Compare February 17, 2024 05:22
@chanijjani
Copy link
Collaborator

image

@chanijjani chanijjani marked this pull request as ready for review February 19, 2024 21:35
@chanijjani
Copy link
Collaborator

chanijjani commented Feb 21, 2024

It is necessary to rebase the main branch to enable CI After #42.
--> [Update] rebased!

@hokeun hokeun marked this pull request as draft February 28, 2024 20:51
@chanijjani chanijjani linked an issue Mar 3, 2024 that may be closed by this pull request
11 tasks
@chanijjani
Copy link
Collaborator

chanijjani commented Mar 8, 2024

@the-systematic-chaos Great to update unit tests of tag.rs! Let me submit a PR to resolve current conflicts in some files.

@chanijjani chanijjani force-pushed the unit_test branch 3 times, most recently from c5a9161 to e949c55 Compare March 8, 2024 00:39
@hokeun hokeun requested a review from chanijjani March 15, 2024 21:24
@chanijjani chanijjani marked this pull request as ready for review March 15, 2024 23:01
Copy link
Collaborator

@chanijjani chanijjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'd better make another PR for the remaining unit TC implementation.

@chanijjani chanijjani merged commit da9bf64 into main Mar 15, 2024
3 checks passed
@chanijjani chanijjani deleted the unit_test branch March 15, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test cases
3 participants