Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make module Python3 compatible. #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lmcinnes
Copy link

@lmcinnes lmcinnes commented Apr 4, 2017

The python module is compatible only with Python2. I have made the minor necessary changes to simultaneously support both Python3 and Python2.

@wlbksy
Copy link

wlbksy commented Jul 25, 2017

it works

@LGro
Copy link

LGro commented Oct 18, 2017

Thanks for the efforts.
Compiling with gcc (GCC) 4.8.5 and installing under Python 3.6.2 :: Continuum Analytics, Inc. I get the following error on import:

ImportError: dynamic module does not define module export function (PyInit_LargeVis)

The solution to this seems to be renaming the function PyInit_myextension(void) in LargeVismodule.cpp:171 to PyInit_LargeVis(void), alongside with the matching change in line 158, where it also still says myextension.
@lmcinnes can you validate this and update your pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants