Update lfortran to v 0.33.0 #28
Conversation
Shaikh-Ubaid
force-pushed
the
update_lfortran
branch
from
138b33e to
c2a5765
Compare
.github/workflows/CI.yml
Outdated
| ./run_tests.py --skip-run-with-dbg --no-llvm --skip-cpptranslate | ||
| ./run_tests.py --skip-cpptranslate |
There was a problem hiding this comment.
In LFortran, there is one reference test that uses the run_with_debug (-g --debug-with-line-column) at the following location
@certik Is the above test sufficient enough for testing the -g --debug-with-line-column or should we add another test (hosted in this repository) for testing it?
There was a problem hiding this comment.
I think that should be sufficient. However you need to disable LLVM tests, or install exactly the same LLVM version that we use, which currently is LLVM 11.
There was a problem hiding this comment.
Actually, it's the LLVM that is used to build lfortran. And that is not LLVM 11, so we can't run the LLVM tests they will fail.
We should only run the debug tests, not LLVM tests.
There was a problem hiding this comment.
Can you revert this change? Let's just upgrade LFortran, ensure all old tests work.
As a separate PR let's try to test the debug info.
There was a problem hiding this comment.
Actually, it's the LLVM that is used to build lfortran. And that is not LLVM 11, so we can't run the LLVM tests they will fail.
Yes, I understand. Thanks. We use llvm 11.0.1 for updating reference tests and in the lfortran-feedstock we use llvm 16.0.6. The reference outputs generated by both the versions do not match.
|
PS: We might need to rerun the CI once LFortran |
Shaikh-Ubaid
force-pushed
the
update_lfortran
branch
from
c2a5765 to
9360385
Compare
Shaikh-Ubaid
changed the title
|
LFortran @certik Do you know how much time it usually takes for conda to work with newer version once that version is uploaded at https://anaconda.org/conda-forge/lfortran/files? |
|
Usually an hour or so. It's already available for me locally on Apple M1. |
No description provided.