Skip to content

Commit

Permalink
use std::shared_ptr and std::make_shared
Browse files Browse the repository at this point in the history
  • Loading branch information
wmtan committed Apr 2, 2016
1 parent 6d75c5e commit c3fdad8
Show file tree
Hide file tree
Showing 18 changed files with 49 additions and 57 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@

// Parser for the adjuster of the adjustable :-)
template<class Jet, class Adjustable>
boost::shared_ptr<AbsFFTJetAdjuster<Jet, Adjustable> >
std::shared_ptr<AbsFFTJetAdjuster<Jet, Adjustable> >
parseFFTJetAdjuster(const edm::ParameterSet& ps, const bool /* verbose */)
{
typedef boost::shared_ptr<AbsFFTJetAdjuster<Jet,Adjustable> > Result;
typedef std::shared_ptr<AbsFFTJetAdjuster<Jet,Adjustable> > Result;

const std::string& adjuster_type = ps.getParameter<std::string>("Class");

Expand All @@ -39,12 +39,12 @@ parseFFTJetAdjuster(const edm::ParameterSet& ps, const bool /* verbose */)

// Parser for the mapper/scaler
template<class Jet, class Adjustable>
boost::shared_ptr<AbsFFTJetScaleCalculator<Jet, Adjustable> >
std::shared_ptr<AbsFFTJetScaleCalculator<Jet, Adjustable> >
parseFFTJetScaleCalculator(const edm::ParameterSet& ps,
gs::StringArchive& ar,
const bool verbose)
{
typedef boost::shared_ptr<AbsFFTJetScaleCalculator<Jet,Adjustable> > Result;
typedef std::shared_ptr<AbsFFTJetScaleCalculator<Jet,Adjustable> > Result;

std::string mapper_type(ps.getParameter<std::string>("Class"));

Expand Down Expand Up @@ -102,18 +102,18 @@ Corrector parseFFTJetCorrector(const edm::ParameterSet& ps,

// "adjuster" is a PSet
const edm::ParameterSet& adjuster = ps.getParameter<edm::ParameterSet>("adjuster");
boost::shared_ptr<const AbsFFTJetAdjuster<MyJet,Adjustable> > adj =
std::shared_ptr<const AbsFFTJetAdjuster<MyJet,Adjustable> > adj =
parseFFTJetAdjuster<MyJet,Adjustable>(adjuster, verbose);

// "scalers" is a VPSet
const std::vector<edm::ParameterSet>& scalers =
ps.getParameter<std::vector<edm::ParameterSet> >("scalers");
const unsigned nScalers = scalers.size();
std::vector<boost::shared_ptr<const AbsFFTJetScaleCalculator<MyJet,Adjustable> > > sVec;
std::vector<std::shared_ptr<const AbsFFTJetScaleCalculator<MyJet,Adjustable> > > sVec;
sVec.reserve(nScalers);
for (unsigned i=0; i<nScalers; ++i)
{
boost::shared_ptr<AbsFFTJetScaleCalculator<MyJet,Adjustable> > s =
std::shared_ptr<AbsFFTJetScaleCalculator<MyJet,Adjustable> > s =
parseFFTJetScaleCalculator<MyJet,Adjustable>(scalers[i], ar, verbose);
sVec.push_back(s);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// system include files
#include <sstream>

#include "boost/shared_ptr.hpp"
#include <memory>

#include "Alignment/Geners/interface/CompressedIO.hh"

Expand All @@ -50,7 +50,7 @@
// record types.
//
template<class CorrectorSequence>
static boost::shared_ptr<CorrectorSequence>
static std::shared_ptr<CorrectorSequence>
buildCorrectorSequence(
const FFTJetCorrectorParameters& tablePars,
const std::vector<edm::ParameterSet>& sequence,
Expand All @@ -70,7 +70,7 @@ buildCorrectorSequence(
}

// Create an empty corrector sequence
boost::shared_ptr<CorrectorSequence> ptr(new CorrectorSequence());
auto ptr = std::make_shared<CorrectorSequence>();

// Go over the parameter sets in the VPSet and
// configure all correction levels. Add each new
Expand Down Expand Up @@ -113,7 +113,7 @@ class FFTJetCorrectionESProducer : public edm::ESProducer
FFTJetCorrectorTransientFromJet,
FFTJetCorrectorResultFromTransient
> CorrectorSequence;
typedef boost::shared_ptr<CorrectorSequence> ReturnType;
typedef std::shared_ptr<CorrectorSequence> ReturnType;
typedef FFTJetCorrectorSequenceRcd<CT> MyRecord;
typedef FFTJetCorrectorParametersRcd<CT> ParentRecord;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <sstream>
#include <utility>

#include <memory>
#include "boost/shared_ptr.hpp"

#include "Alignment/Geners/interface/CompressedIO.hh"
Expand Down Expand Up @@ -52,7 +53,7 @@ static void insertLUTItem(FFTJetLookupTableSequence& seq,
it->second.insert(std::make_pair(name, fptr));
}

static boost::shared_ptr<FFTJetLookupTableSequence>
static std::shared_ptr<FFTJetLookupTableSequence>
buildLookupTables(
const FFTJetCorrectorParameters& tablePars,
const std::vector<edm::ParameterSet>& tableDefs,
Expand All @@ -68,8 +69,7 @@ buildLookupTables(
ar = gs::read_item<gs::StringArchive>(is);
}

boost::shared_ptr<FFTJetLookupTableSequence> ptr(
new FFTJetLookupTableSequence());
auto ptr = std::make_shared<FFTJetLookupTableSequence>();

// Avoid loading the same item more than once
std::set<unsigned long long> loadedSet;
Expand Down Expand Up @@ -112,7 +112,7 @@ template<typename CT>
class FFTJetLookupTableESProducer : public edm::ESProducer
{
public:
typedef boost::shared_ptr<FFTJetLookupTableSequence> ReturnType;
typedef std::shared_ptr<FFTJetLookupTableSequence> ReturnType;
typedef FFTJetLookupTableRcd<CT> MyRecord;
typedef FFTJetCorrectorParametersRcd<CT> ParentRecord;

Expand Down
10 changes: 5 additions & 5 deletions JetMETCorrections/FFTJetObjects/interface/FFTJetCorrector.h
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#ifndef JetMETCorrections_FFTJetObjects_FFTJetCorrector_h
#define JetMETCorrections_FFTJetObjects_FFTJetCorrector_h

#include <memory>
#include <vector>
#include <boost/shared_ptr.hpp>

#include "JetMETCorrections/FFTJetObjects/interface/AbsFFTJetAdjuster.h"
#include "JetMETCorrections/FFTJetObjects/interface/AbsFFTJetScaleCalculator.h"
Expand All @@ -17,8 +17,8 @@ class FFTJetCorrector
typedef AbsFFTJetScaleCalculator<jet_type, adjustable_type> AbsScaler;
typedef AbsFFTJetAdjuster<jet_type, adjustable_type> AbsAdjuster;

inline FFTJetCorrector(boost::shared_ptr<const AbsAdjuster> adjuster,
const std::vector<boost::shared_ptr<const AbsScaler> >& scalers,
inline FFTJetCorrector(std::shared_ptr<const AbsAdjuster> adjuster,
const std::vector<std::shared_ptr<const AbsScaler> >& scalers,
const unsigned i_level, const FFTJetCorrectorApp a)
: adjuster_(adjuster), scalers_(scalers),
level_(i_level), app_(a) {}
Expand Down Expand Up @@ -56,8 +56,8 @@ class FFTJetCorrector
inline FFTJetCorrectorApp app() const {return app_;}

private:
boost::shared_ptr<const AbsAdjuster> adjuster_;
std::vector<boost::shared_ptr<const AbsScaler> > scalers_;
std::shared_ptr<const AbsAdjuster> adjuster_;
std::vector<std::shared_ptr<const AbsScaler> > scalers_;
unsigned level_;
FFTJetCorrectorApp app_;
};
Expand Down
6 changes: 3 additions & 3 deletions JetMETCorrections/Modules/interface/JetCorrectionESChain.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
//

#include <string>
#include <memory>
#include <vector>
#include "boost/shared_ptr.hpp"

#include "FWCore/Framework/interface/ESProducer.h"

Expand All @@ -25,10 +25,10 @@ class JetCorrectionESChain : public edm::ESProducer {
JetCorrectionESChain(edm::ParameterSet const& fParameters);
~JetCorrectionESChain();

boost::shared_ptr<JetCorrector> produce(JetCorrectionsRecord const& );
std::shared_ptr<JetCorrector> produce(JetCorrectionsRecord const& );

private:
std::vector <std::string> mCorrectors;
boost::shared_ptr<JetCorrector> mChainCorrector;
std::shared_ptr<JetCorrector> mChainCorrector;
};
#endif
7 changes: 3 additions & 4 deletions JetMETCorrections/Modules/interface/JetCorrectionESProducer.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
//

#include <string>
#include "boost/shared_ptr.hpp"
#include <memory>

#include "FWCore/Framework/interface/ModuleFactory.h"
#include "FWCore/Framework/interface/ESProducer.h"
Expand Down Expand Up @@ -42,13 +42,12 @@ class JetCorrectionESProducer : public edm::ESProducer

~JetCorrectionESProducer() {}

boost::shared_ptr<JetCorrector> produce(JetCorrectionsRecord const& iRecord)
std::shared_ptr<JetCorrector> produce(JetCorrectionsRecord const& iRecord)
{
edm::ESHandle<JetCorrectorParametersCollection> JetCorParColl;
iRecord.get(mAlgo,JetCorParColl);
JetCorrectorParameters const& JetCorPar = (*JetCorParColl)[mLevel];
boost::shared_ptr<JetCorrector> mCorrector(new Corrector(JetCorPar, mParameterSet));
return mCorrector;
return std::make_shared<Corrector>(JetCorPar, mParameterSet);
}
};
#endif
7 changes: 3 additions & 4 deletions JetMETCorrections/Modules/interface/JetCorrectionESSource.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Created: Dec. 28, 2006 (originally JetCorrectionService, renamed in 2011)
//

#include "boost/shared_ptr.hpp"
#include <memory>
#include <string>
#include <iostream>

Expand Down Expand Up @@ -60,7 +60,7 @@ class JetCorrectionESSource : public edm::ESProducer,

~JetCorrectionESSource() {}

boost::shared_ptr<JetCorrector> produce(JetCorrectionsRecord const& iRecord)
std::shared_ptr<JetCorrector> produce(JetCorrectionsRecord const& iRecord)
{
std::string fileName("CondFormats/JetMETObjects/data/");
if (!mEra.empty())
Expand All @@ -74,8 +74,7 @@ class JetCorrectionESSource : public edm::ESProducer,
std::cout << "Parameter File: " << fileName << std::endl;
edm::FileInPath fip(fileName);
JetCorrectorParameters *tmpJetCorPar = new JetCorrectorParameters(fip.fullPath(), mSection);
boost::shared_ptr<JetCorrector> mCorrector(new Corrector(*tmpJetCorPar, mParameterSet));
return mCorrector;
return std::make_shared<Corrector>(*tmpJetCorPar, mParameterSet);
}

void setIntervalFor(edm::eventsetup::EventSetupRecordKey const&, edm::IOVSyncValue const&, edm::ValidityInterval& fIOV)
Expand Down
10 changes: 5 additions & 5 deletions JetMETCorrections/Modules/interface/JetResolutionESProducer.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//

#include <string>
#include "boost/shared_ptr.hpp"
#include <memory>

#include "FWCore/Framework/interface/ModuleFactory.h"
#include "FWCore/Framework/interface/ESProducer.h"
Expand All @@ -31,15 +31,15 @@ class JetResolutionESProducer : public edm::ESProducer

~JetResolutionESProducer() {}

boost::shared_ptr<JME::JetResolution> produce(JetResolutionRcd const& iRecord) {
std::shared_ptr<JME::JetResolution> produce(JetResolutionRcd const& iRecord) {

// Get object from record
edm::ESHandle<JME::JetResolutionObject> jerObjectHandle;
iRecord.get(m_label, jerObjectHandle);

// Convert this object to a JetResolution object
JME::JetResolutionObject const& jerObject = (*jerObjectHandle);
return boost::shared_ptr<JME::JetResolution>(new JME::JetResolution(jerObject));
return std::make_shared<JME::JetResolution>(jerObject);
}
};

Expand All @@ -57,15 +57,15 @@ class JetResolutionScaleFactorESProducer : public edm::ESProducer

~JetResolutionScaleFactorESProducer() {}

boost::shared_ptr<JME::JetResolutionScaleFactor> produce(JetResolutionScaleFactorRcd const& iRecord) {
std::shared_ptr<JME::JetResolutionScaleFactor> produce(JetResolutionScaleFactorRcd const& iRecord) {

// Get object from record
edm::ESHandle<JME::JetResolutionObject> jerObjectHandle;
iRecord.get(m_label, jerObjectHandle);

// Convert this object to a JetResolution object
JME::JetResolutionObject const& jerObject = (*jerObjectHandle);
return boost::shared_ptr<JME::JetResolutionScaleFactor>(new JME::JetResolutionScaleFactor(jerObject));
return std::make_shared<JME::JetResolutionScaleFactor>(jerObject);
}
};
#endif
3 changes: 1 addition & 2 deletions JetMETCorrections/Modules/interface/QGLikelihoodESProducer.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

// system include files
#include <memory>
#include "boost/shared_ptr.hpp"

// user include files
#include "FWCore/Framework/interface/ModuleFactory.h"
Expand All @@ -22,7 +21,7 @@ class QGLikelihoodESProducer : public edm::ESProducer{
QGLikelihoodESProducer(const edm::ParameterSet&);
~QGLikelihoodESProducer(){};

boost::shared_ptr<QGLikelihoodObject> produce(const QGLikelihoodRcd&);
std::shared_ptr<QGLikelihoodObject> produce(const QGLikelihoodRcd&);
void setIntervalFor(const edm::eventsetup::EventSetupRecordKey &, const edm::IOVSyncValue &, edm::ValidityInterval &);

private:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

// system include files
#include <memory>
#include "boost/shared_ptr.hpp"

// user include files
#include "FWCore/Framework/interface/ModuleFactory.h"
Expand All @@ -22,7 +21,7 @@ class QGLikelihoodSystematicsESProducer : public edm::ESProducer{
QGLikelihoodSystematicsESProducer(const edm::ParameterSet&);
~QGLikelihoodSystematicsESProducer(){};

boost::shared_ptr<QGLikelihoodSystematicsObject> produce(const QGLikelihoodSystematicsRcd&);
std::shared_ptr<QGLikelihoodSystematicsObject> produce(const QGLikelihoodSystematicsRcd&);
void setIntervalFor(const edm::eventsetup::EventSetupRecordKey &, const edm::IOVSyncValue &, edm::ValidityInterval &);
private:
std::string mAlgo;
Expand Down
2 changes: 1 addition & 1 deletion JetMETCorrections/Modules/src/JetCorrectionESChain.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ JetCorrectionESChain::JetCorrectionESChain(edm::ParameterSet const& fParameters)

JetCorrectionESChain::~JetCorrectionESChain() {}

boost::shared_ptr<JetCorrector> JetCorrectionESChain::produce(JetCorrectionsRecord const& fRecord) {
std::shared_ptr<JetCorrector> JetCorrectionESChain::produce(JetCorrectionsRecord const& fRecord) {
ChainedJetCorrector* corrector = dynamic_cast<ChainedJetCorrector*>(&*mChainCorrector);
corrector->clear ();
for (size_t i = 0; i < mCorrectors.size(); ++i) {
Expand Down
8 changes: 4 additions & 4 deletions JetMETCorrections/Modules/src/JetResolution.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
namespace JME {

JetResolution::JetResolution(const std::string& filename) {
m_object = std::shared_ptr<JetResolutionObject>(new JetResolutionObject(filename));
m_object = std::make_shared<JetResolutionObject>(filename);
}

JetResolution::JetResolution(const JetResolutionObject& object) {
m_object = std::shared_ptr<JetResolutionObject>(new JetResolutionObject(object));
m_object = std::make_shared<JetResolutionObject>(object);
}

#ifndef STANDALONE
Expand All @@ -37,11 +37,11 @@ namespace JME {
}

JetResolutionScaleFactor::JetResolutionScaleFactor(const std::string& filename) {
m_object = std::shared_ptr<JetResolutionObject>(new JetResolutionObject(filename));
m_object = std::make_shared<JetResolutionObject>(filename);
}

JetResolutionScaleFactor::JetResolutionScaleFactor(const JetResolutionObject& object) {
m_object = std::shared_ptr<JetResolutionObject>(new JetResolutionObject(object));
m_object = std::make_shared<JetResolutionObject>(object);
}

#ifndef STANDALONE
Expand Down
5 changes: 2 additions & 3 deletions JetMETCorrections/Modules/src/QGLikelihoodESProducer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,9 @@ void QGLikelihoodESProducer::setIntervalFor(const edm::eventsetup::EventSetupRec
}

// Produce the data
boost::shared_ptr<QGLikelihoodObject> QGLikelihoodESProducer::produce(const QGLikelihoodRcd& iRecord){
std::shared_ptr<QGLikelihoodObject> QGLikelihoodESProducer::produce(const QGLikelihoodRcd& iRecord){
edm::ESHandle<QGLikelihoodObject> qglObj;
iRecord.get(mAlgo, qglObj);

boost::shared_ptr<QGLikelihoodObject> pMyType(new QGLikelihoodObject(*qglObj));
return pMyType;
return std::make_shared<QGLikelihoodObject>(*qglObj);
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,9 @@ void QGLikelihoodSystematicsESProducer::setIntervalFor(const edm::eventsetup::Ev
}

// Produce the data
boost::shared_ptr<QGLikelihoodSystematicsObject> QGLikelihoodSystematicsESProducer::produce(const QGLikelihoodSystematicsRcd& iRecord){
std::shared_ptr<QGLikelihoodSystematicsObject> QGLikelihoodSystematicsESProducer::produce(const QGLikelihoodSystematicsRcd& iRecord){
edm::ESHandle<QGLikelihoodSystematicsObject> qglObj;
iRecord.get(mAlgo, qglObj);

boost::shared_ptr<QGLikelihoodSystematicsObject> pMyType(new QGLikelihoodSystematicsObject(*qglObj));
return pMyType;
return std::make_shared<QGLikelihoodSystematicsObject>(*qglObj);
}
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ FWLiteESRecordWriterAnalyzer::update(const edm::EventSetup& iSetup)
}
dataInfos.push_back(DataInfo(tt,itData->second));
}
m_handlers.push_back( std::shared_ptr<RecordHandler>( new RecordHandler(rKey,m_file,dataInfos) ) );
m_handlers.push_back( std::make_shared<RecordHandler>(rKey,m_file,dataInfos) );
}
}

Expand Down
2 changes: 1 addition & 1 deletion PhysicsTools/CondLiteIO/plugins/FWLiteESSource.cc
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ FWLiteESSource::registerProxies(const edm::eventsetup::EventSetupRecordKey& iRec
if(tt != HCTypeTag() ) {
edm::eventsetup::DataKey dk(tt,edm::eventsetup::IdTags(it->second.c_str()));
aProxyList.push_back(std::make_pair(dk,
std::shared_ptr<edm::eventsetup::DataProxy>(new FWLiteProxy(TypeID(tt.value()),&rec))));
std::make_shared<FWLiteProxy>(TypeID(tt.value()),&rec)));
} else {
LogDebug("UnknownESType")<<"The type '"<<it->first<<"' is unknown in this job";
std::cout <<" *****FAILED*****"<<std::endl;
Expand Down
Loading

0 comments on commit c3fdad8

Please sign in to comment.