Skip to content

Commit

Permalink
Work around Miri failures
Browse files Browse the repository at this point in the history
Recent nightly version of Rust fail running one of our tests under Miri
[0]. The claim is that data is used uninitialized, but it's not really
clear why there would be anything uninitialized at this point and this
test has been working fine ever since its inception. Suspicion is that
nightly Miri could have a bug. And even if it's a bug in our code it
would be in test code itself, rather than the library. Pin the version
we use to a known good one for the time being to get us back to green.

[0] https://github.com/libbpf/blazesym/actions/runs/10842437849/job/30216935620

Signed-off-by: Daniel Müller <[email protected]>
  • Loading branch information
d-e-s-o committed Sep 17, 2024
1 parent b607971 commit cf9a687
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,12 @@ jobs:
MIRIFLAGS: '-Zmiri-disable-stacked-borrows'
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@nightly
- uses: dtolnay/rust-toolchain@master
with:
# TODO: Recent nightly versions fail with what *seems* to be a
# false positive. Fall back to a known good version. We
# should come back to this eventually.
toolchain: nightly-2024-08-06
components: miri
# Miri would honor our custom test runner, but doesn't work with it. We
# could conceivably override that by specifying
Expand Down

0 comments on commit cf9a687

Please sign in to comment.