capi: Bubble up blaze_syms allocation errors properly #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convert_symbolizedresults_to_c() is a fallible function, but so far we have not checked its result but just returned it straight away. That can result in a NULL pointer being returned without an error code set. Despite being highly unlikely (Rust code would just panic earlier on allocation failure) as it's only our C layer that handles these situations more gracefully, this is not ideal and counter to our stated contract. Make sure to check the function's return value and set the last error accordingly. Signed-off-by: Daniel Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert_symbolizedresults_to_c() is a fallible function, but so far we have not checked its result but just returned it straight away. That can result in a NULL pointer being returned without an error code set. Despite being highly unlikely (Rust code would just panic earlier on allocation failure) as it's only our C layer that handles these situations more gracefully, this is not ideal and counter to our stated contract.
Make sure to check the function's return value and set the last error accordingly.