Family creation from families #267 #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlislefox
reviewed
Apr 18, 2023
| public final Builder concat (Family... families) { | ||
| for(Family family : families){ | ||
| one.or(family.one); | ||
| all.or(family.all); |
There was a problem hiding this comment.
Can this formatting be altered to be consistent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a Familty from another
Family family2 = Family.one(ComponentF.class).concat(family1).get();Allow to call one/all/exclude more than one time in FamilyBuilder
Before
Family family2 = Family.one(ComponentA.class).one(ComponentB.class).get();allow only componentB, now ComponentA is not delete.
Thanks for reading.