Removes the flexvolume API #732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Solé <[email protected]>
Signed-off-by: Marc Solé <[email protected]>
This reverts commit 7900eb6.
|
I merged this change and the one that adds the possibility to select a custom Gossip port, which was not desired. Trying to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marc Solé [email protected]
What this PR does / why we need it:
Removes the installation, usage and configuration of the Flexvolume API. As long as I heard, it is no longer used so I think it is safe to remove it to prevent the usage of one port. Please check this.
Which issue(s) this PR fixes (optional)
Closes #210 #165 and helps with #720
Special notes for your reviewer:
I just deleted all the instances of the Flexvolume API in the code, not only the ones related to the usage but also the ones related to the installation and the dependencies. Because of this, I did not add code so I think it is safe to neither add unit-tests.
I checked the functionality and the tests performed are working correctly. However, you should still take a look to it because maybe I missed something because of not being used to this code.