Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix race in TestRemoveConnByUfrag #2620

Merged
merged 1 commit into from
Oct 26, 2023
+9 −3
Merged

webrtc: fix race in TestRemoveConnByUfrag #2620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions p2p/transport/webrtc/udpmux/mux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ func TestRemoveConnByUfrag(t *testing.T) {
for i := 0; i < 10; i++ {
mc1, err := m.GetConn(ufrag, conns[i].LocalAddr())
require.NoError(t, err)
require.Equal(t, mc1, mc)
if mc1 != mc {
t.Fatalf("expected the two muxed connections to be same")
}
}

// Now remove the ufrag
Expand All @@ -167,13 +169,17 @@ func TestRemoveConnByUfrag(t *testing.T) {
for i := 0; i < 10; i++ {
mc1, err := m.GetConn(ufrag, conns[i].LocalAddr())
require.NoError(t, err)
require.Equal(t, mc1, mc)
if mc1 != mc {
t.Fatalf("expected the two muxed connections to be same")
}
}

// Should be different even if the address is the same
mc1, err := m.GetConn("a", conns[0].LocalAddr())
require.NoError(t, err)
require.NotEqual(t, mc1, mc)
if mc1 == mc {
t.Fatalf("expected the two connections to be different")
}
}

func TestMuxedConnection(t *testing.T) {
Expand Down