fix: removing stream methods from connection interface #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the discussion from [this pull request](libp2p/js-libp2p-interfaces#417), PR was originally opened in js-libp2p-interfaces before being moving to this monorepo the muxers should be ultimately responsible for managing streams, that's why `addStream` and `removeStream` methods are being removed from the interface https://github.com/libp2p/js-libp2p-interfaces/pull/417/files#r1230570032
maschad
requested changes
Jun 15, 2023
There was a problem hiding this comment.
Thanks for opening this PR, really appreciate the input. Given this is an interface though, it will cause a breaking change in any class that implements this interface could you remove the methods there as well?
|
It's probably worth rebasing this once #1833 is in as it'll show the full scope of the change across the stack. |
mmsaki
changed the title
mmsaki
changed the title
|
Closing in favour of #1912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the discussion from this pull request, PR was originally opened in js-libp2p-interfaces before being moving to this monorepo
the muxers should be ultimately responsible for managing streams, that's why
addStreamandremoveStreammethods are being removed from the interface seeFixes issue libp2p/js-libp2p#1855