Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(identify): migrate tests from async-std to tokio #5849

Merged
merged 3 commits into from
Feb 5, 2025
Merged

chore(identify): migrate tests from async-std to tokio #5849

merged 3 commits into from
Feb 5, 2025

Conversation

shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Feb 5, 2025 •
edited
Loading

Description

Migrating tests in protocols/identify from async_std to tokio as per #4449

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

elenaf9
elenaf9 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jxs jxs added the send-it label Feb 5, 2025
@mergify mergify bot merged commit c78de35 into libp2p:master Feb 5, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenaf9 elenaf9 elenaf9 approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiyasmohd @elenaf9 @jxs