Stop using external parser services #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havocp
approved these changes
Nov 26, 2024
| dependencies = call_conda_parser_web(info, kind)[kind.to_sym] | ||
| dependencies.map { |dep_kv| Dependency.new(**dep_kv.merge(type: "runtime")) } | ||
| end | ||
| def self.parse_name_requirement_from_matchspec(ms) |
There was a problem hiding this comment.
if a regex is two problems there are a lot of problems here 😂
This stops using yarn-parser and instead does parsing locally for yarn.lock (v1 and v2)
Parse conda's environment.yaml file natively by reimplementing the version parsing from MatchSpec. Also drops support for our fake environment.yml.lock "lockfile" as we should instead generate something client side vs trying to fake a solve here
Removes the other parsers which require an external parser service as they reduce overall reliability
katzj
force-pushed
the
no-external-parsers
branch
from
43ee92e to
ee37ac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty substantial change in that it stops doing any parsing of manifests by sending things over the network to a parsing service. To do so, it drops support for parsing carthage, clojars, hackage, hex, and swift manifest files. But none of these end up being parsed from within libraries and we don't support them.
For yarn and conda, which had external parser services, I've written logic that can live within as they're both relatively easy to parse natively. Individual commits should make sense