Fixed /discovery/list failing with multiple clients on the network (#…

…352)
librespot-org · May 11, 2021 · 2745b50 · 2745b50
1 parent c9f9f53
commit 2745b50
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/api/src/main/java/xyz/gianlu/librespot/api/handlers/DiscoveryHandler.java b/api/src/main/java/xyz/gianlu/librespot/api/handlers/DiscoveryHandler.java
@@ -37,10 +37,10 @@
  */
 public final class DiscoveryHandler implements HttpHandler {
     private static final Logger LOGGER = LoggerFactory.getLogger(DiscoveryHandler.class);
-    private final Zeroconf zeroconf;
+    private final Zeroconf.DiscoveredServices discoverer;
 
     public DiscoveryHandler() {
-        zeroconf = new Zeroconf()
+        Zeroconf zeroconf = new Zeroconf()
                 .setUseIpv4(true)
                 .setUseIpv6(false);
 
@@ -49,6 +49,8 @@ public DiscoveryHandler() {
         } catch (IOException ex) {
             LOGGER.error("Failed adding network interfaces for Zeroconf.", ex);
         }
+
+        discoverer = zeroconf.discover(ZeroconfServer.SERVICE, "tcp", ".local");
     }
 
     @Override
@@ -69,7 +71,7 @@ public void handleRequest(HttpServerExchange exchange) throws Exception {
         switch (action) {
             case "list":
                 JsonArray array = new JsonArray();
-                for (DiscoveredService service : zeroconf.discover(ZeroconfServer.SERVICE, "tcp", ".local")) {
+                for (DiscoveredService service : discoverer.getServices()) {
                     JsonObject obj = new JsonObject();
                     obj.addProperty("name", service.name);
                     obj.addProperty("target", service.target);

diff --git a/lib/pom.xml b/lib/pom.xml
@@ -116,7 +116,7 @@
         <dependency>
             <groupId>xyz.gianlu.zeroconf</groupId>
             <artifactId>zeroconf</artifactId>
-            <version>1.2.2</version>
+            <version>1.3.0</version>
         </dependency>
 
         <!-- HTTP -->