Cargo replace hex with data-encoding #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-encoding was already a transitive dependency via tungstenite
|
Looks good to me, thanks. If iOS is broken then that can be fixed as a separate thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, let's try #1227 again but now with more feeling...
data-encodingwas already a transitive dependency of tungstenite so this changeset strictly reduces the dep set of the project.I've also added some improved logging and made it easier to spoof the OS type by moving the side effect to a single line in
spclientand parameterizing the use sites.I tested the hashcash challenge with
"ios"and found I could stream music (but there were other complaints about 502 responses to some requests and sometimes my decrepit machine was too slow to solve the challenge).