Update hyper to 1.x #1291
Merged
Update hyper to 1.x #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyper's `server` feature is not always enabled. The `hyper::Error::is_parse_too_large` function isn't included when `server` isn't enabled. Fortunately, it doesn't matter to us: `Error:is_parse` matches `parse_too_large` errors, so removing this check does not change behavior whatsoever.
|
Thanks a lot for this! I went through it and it looks good. If someone could also verify on some *nix? |
|
Built it locally on linux and played back two songs successfully. |
|
Great, let's merge! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
hyperto version 1.x. I've tested it on windows with default options. The most notable change is in the discovery server, where the code has changed significantly to accommodate changes inhyper. The intent of the code remains the same, and I confirmed that it functions correctly on my devices.hyper-proxyis swapped out in favor of a maintained fork,hyper-proxy2. I've seen mentions of some alternatives; this appears to be the most stable option.hyper-rustlsis updated to version0.26.0to gethyper1.x support, but is held short of the latest version,0.27.2, due to build environment changes required for0.27.0.Docs I referenced for this change:
hyper,hyper-util,hyper-body-util