Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build examples + Fix SDL3 examples #506

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Apr 18, 2024

No description provided.

@madebr
Copy link
Contributor Author

madebr commented Apr 18, 2024

The remaining failing SDL3 examples are android symbols, and documentation pages where the example is basically:

    ```c++
    You can add your code example here
    ```

SDL_GL_BindTexture is also failing. Its example is probably way too complicated.

@madebr
Copy link
Contributor Author

madebr commented Apr 18, 2024

The remaining failing SDL3 examples are android symbols, and documentation pages where the example is basically:

    ```c++
    You can add your code example here
    ```

SDL_GL_BindTexture is also failing. Its example is probably way too complicated.

I removed those example blocks, and it turned out SDL_GL_BindTexture was removed from SDL3. :)

@icculus
Copy link
Contributor

icculus commented Apr 18, 2024

This is cool. :)

@icculus icculus merged commit 4828b8d into libsdl-org:main Apr 18, 2024
1 check passed
@icculus
Copy link
Contributor

icculus commented Apr 18, 2024

Should the #!/usr/bin/env python in extract_example.py use python3 instead? This is probably just needs to work on GitHub Actions, so not a big deal, but on Ubuntu 23.04, it fails if you try to run it with python, which is 2.7.18 in this case.

@madebr madebr deleted the build-examples branch April 18, 2024 19:58
@madebr
Copy link
Contributor Author

madebr commented Apr 18, 2024

Should the #!/usr/bin/env python in extract_example.py use python3 instead? This is probably just needs to work on GitHub Actions, so not a big deal, but on Ubuntu 23.04, it fails if you try to run it with python, which is 2.7.18 in this case.

Yeah probably.
I assumed most distributions changed the /usr/bin/python symlink to python3 by now.
The CMake script uses Python3, so it does not really matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants