-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of BMat16 #38
base: main
Are you sure you want to change the base?
Conversation
Closing and reopening to trigger the ci again |
1591168
to
76df096
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried BMat16's with libsemigroups (basically dropping it in everywhere we use HPCombi::BMat8 in the tests) and found no issues whatsoever. So I'm happy to merge this if you are @hivert ?
I'd like to look a little at the generated assembly code to check that some think are properly optimized by the (a) compiler (notably some product by power of 2 which could be written as shift). I try to do it either during the week-end or next week. Other than that, I'm Ok to merge. |
Here are the additions regarding BMat16 :