-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "coep: credentialless" with credentialless iframes on all pages on Chrome 110+ #12183
Use "coep: credentialless" with credentialless iframes on all pages on Chrome 110+ #12183
Conversation
Ugh, turns out for Twitter embeds, the iframe is created by a Twitter script which ofc doesn't add the attribute. I guess really, we'd just want a header to tell the browser "make all the iframes credentialless". Filed WICG/anonymous-iframe#14 to make the chrome devs aware of the issue. I guess one kinda ugly workaround would be to add our own The alternative would be to keep all pages with possible Twitter embeds without the header. I guess that would be the forum and all (official + user) blog posts. Potentially could check whether the page actually contains a Twitter link but that might be a bit of a mess. |
If the only obstacle left is twitter embeds, I'm happy to remove them altogether. |
0414a45
to
7305cad
Compare
Small update here: For the twitter embeds, in the issue I filed, a Chromium dev proposed polyfilling Otherwise, the attribute is now in stable Chrome (actually already since the previous version now) but while testing earlier, I noticed that YouTube embeds with the |
Not sure if this is needed but I guess doesn't hurt
06a3533
to
fb6e335
Compare
Ok, it looks like Chrome finally fixed the crash in 113 which was rolled out a bit ago. I just did a few more tests checking YT and Twitter embeds and the analysis board and didn't notice any more issues. |
Second attempt at #11614
Using the "credentialless" (formerly called "anonymous") attribute on iframes new in Chrome 110 to make YT/Twitch embeds work:
Chrome 110 just got released on the dev channel and should become stable in 4 weeks so probably still a bit early to merge but from cursory testing, everything seems to work. Probably still should be tested on .dev a bit once 110 is stable.
Also, I guess might make sense to create a custom iframe tag or something to always set the attribute?