Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When game ratingDiff is zero (e.g. draw), color should be yellow instead of red #1382

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cioccarellia
Copy link

In the game UI, when a draw happens between two players, the rating difference is zero.
The game colors the rating diff text with red, but that is inconsistent w.r.t. the home game list, where draw results are shown in yellow.
A more consistent color approach would be to have the zero rating delta in yellow (so that it more accurately represents the rating difference).

@veloce
Copy link
Contributor

veloce commented Jan 28, 2025

Your code is not formatted properly, which is why the tests are failing. You can use dart format to format the code, or better, setup your editor to do it, thanks.

@cioccarellia
Copy link
Author

I tried running dart format on the file but it looks like maybe the formatter I used has different settings w.r.t. the one in the pipeline (sorry for the trouble, I'm not really familiar with dart/flutter)

@veloce
Copy link
Contributor

veloce commented Jan 29, 2025

The formatter is configured for the project here:

formatter:

Your formatter normally would automatically pick these settings. Or if you run dart format from the project root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants