Skip to content

Commit

Permalink
Fixed a url parsing bug
Browse files Browse the repository at this point in the history
Fixed a url parsing bug  exposed by the newest url-parse module which
caused the URL passed to the lambda to be missing a leading forward
slash.
  • Loading branch information
Anthony Roach committed Feb 18, 2021
1 parent 78a597d commit 0b78a33
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.4.1] - 2020-02-18
### Fixed
- Fixed a url parsing bug exposed by the newest url-parse module which caused
the URL passed to the lambda to be missing a leading forward slash.

## [1.3.1] - 2020-11-12
### Fixed
- Move away from module declarations due to limitations (cannot export types
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"lodash": "^4.17.20",
"nearley": "^2.19.7",
"resolve-pathname": "^3.0.0",
"url-parse": "^1.4.7"
"url-parse": "^1.5.0"
},
"publishConfig": {
"access": "public"
Expand Down
3 changes: 2 additions & 1 deletion src/adapters/helpers/lambdaEvent.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ const urlParse = require('url-parse');
const querystring = require('querystring');

module.exports = (config, relativeUrl) => {
const parts = urlParse(relativeUrl || config.url, null, querystringWithArraySupport);
// url-parse needs a location to properly handle relative urls, so provide a fake one here:
const parts = urlParse(relativeUrl || config.url, 'http://fake', querystringWithArraySupport);
const params = Object.assign({}, parts.query, config.params);

const event = {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5754,10 +5754,10 @@ url-parse-lax@^3.0.0:
dependencies:
prepend-http "^2.0.0"

url-parse@^1.4.7:
version "1.4.7"
resolved "https://registry.yarnpkg.com/url-parse/-/url-parse-1.4.7.tgz#a8a83535e8c00a316e403a5db4ac1b9b853ae278"
integrity sha512-d3uaVyzDB9tQoSXFvuSUNFibTd9zxd2bkVrDRvF5TmvWWQwqE4lgYJ5m+x1DbecWkw+LK4RNl2CU1hHuOKPVlg==
url-parse@^1.5.0:
version "1.5.0"
resolved "https://registry.yarnpkg.com/url-parse/-/url-parse-1.5.0.tgz#90aba6c902aeb2d80eac17b91131c27665d5d828"
integrity sha512-9iT6N4s93SMfzunOyDPe4vo4nLcSu1yq0IQK1gURmjm8tQNlM6loiuCRrKG1hHGXfB2EWd6H4cGi7tGdaygMFw==
dependencies:
querystringify "^2.1.1"
requires-port "^1.0.0"
Expand Down

0 comments on commit 0b78a33

Please sign in to comment.