Deploy Across Fix to Worldchain

[ezynda3]

Which Jira task belongs to this PR?

Why did I implement it this way?

Checklist before requesting a review

• I have performed a self-review of my code
• This pull request is as small as possible and only tackles one problem
• I have added tests that cover the functionality / test the bug
• For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• I have checked that any arbitrary calls to external contracts are validated and or restricted
• I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai]

Walkthrough

This pull request involves updates to three JSON deployment files. The changes include correcting the JSON syntax in the _deployments_log_file.json by adding proper closing braces and brackets, updating the worldchain.diamond.json with a new AcrossFacetV3 facet entry, and modifying the worldchain.json file to update the address of the AcrossFacetV3 to a new address.

Changes

File	Change Summary
deployments/_deployments_log_file.json	Added closing braces and brackets to correct JSON syntax
deployments/worldchain.diamond.json	Added new AcrossFacetV3 facet with version 1.1.0 and address 0x08F7800449ad6681bd607EF21d3cc9C9dDDaF1C8
deployments/worldchain.json	Updated AcrossFacetV3 address from 0x5052fc5c7486162deDf7458E1f7c6ABaFbcd6895 to 0x08F7800449ad6681bd607EF21d3cc9C9dDDaF1C8

Possibly related PRs

• Deploy Across Fix to Prod #914: Changes in deployments/_deployments_log_file.json involving new entries and modifications

Suggested labels

AuditNotRequired

Suggested reviewers

• maxklenk

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb12d93 and bfd44e8.

📒 Files selected for processing (3)

• deployments/_deployments_log_file.json (1 hunks)
• deployments/worldchain.diamond.json (2 hunks)
• deployments/worldchain.json (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• deployments/_deployments_log_file.json
• deployments/worldchain.json

🧰 Additional context used

📓 Learnings (1)

deployments/worldchain.diamond.json (2)

Learnt from: 0xDEnYO
PR: lifinance/contracts#782
File: deployments/worldchain.diamond.json:40-43
Timestamp: 2024-11-26T01:16:27.721Z
Learning: Version inconsistencies of 'GenericSwapFacetV3' across deployment configurations are acceptable if they are only due to differences in Solidity pragma directives.

Learnt from: 0xDEnYO
PR: lifinance/contracts#782
File: deployments/worldchain.diamond.json:5-63
Timestamp: 2024-11-26T01:14:58.163Z
Learning: When facet versions are set to empty strings in `deployments/*.diamond.json` files, do not report this issue, as it is already known and will be addressed separately.

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: enforce-min-test-coverage
• GitHub Check: run-unit-tests
• GitHub Check: run-unit-tests
• GitHub Check: enforce-min-test-coverage
• GitHub Check: generate-tag
• GitHub Check: analyze

🔇 Additional comments (3)

deployments/worldchain.diamond.json (3)

67-70: LGTM! New facet entry is properly configured.

The new AcrossFacetV3 facet is correctly added with proper version numbering and address format.

---

67-70: Verify the coexistence of multiple Across facets.

The configuration now includes both AcrossFacetV3 (1.1.0) and AcrossFacetPackedV3 (1.0.0). Please confirm if both facets are intended to be active simultaneously.

Run this script to check for potential conflicts:

Also applies to: 90-93

✅ Verification successful

Coexistence of Across facets is intentional and properly designed

The AcrossFacetV3 (1.1.0) and AcrossFacetPackedV3 (1.2.0) are complementary implementations:

• V3: Standard implementation with full feature set
• PackedV3: Gas-optimized version with packed calldata for efficiency

Both facets serve different use cases while maintaining the same core bridge functionality, making their coexistence beneficial rather than problematic.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for function selector conflicts between Across facets

# Search for function selectors in both facet contracts
ast-grep --pattern 'function $$$($$$) $$$' | grep -A 1 'Across'

# Check deployment history for any related migrations
git log -p -- deployments/worldchain.diamond.json | grep -A 5 -B 5 'Across'

Length of output: 63

---

Script:

#!/bin/bash
# First, find relevant Across facet files
fd -e sol "Across.*Facet"

# Then examine the deployment configuration
cat deployments/worldchain.diamond.json | jq -r '.facets | to_entries[] | select(.value.Name | contains("Across"))'

# Search for any migration or upgrade related files
fd -t f "migration|upgrade" -E "node_modules"

Length of output: 1200

---

Script:

#!/bin/bash
# Examine V3 implementations
echo "=== AcrossFacetV3 Functions ==="
ast-grep --pattern 'function $$$($$$) $$$' src/Facets/AcrossFacetV3.sol

echo -e "\n=== AcrossFacetPackedV3 Functions ==="
ast-grep --pattern 'function $$$($$$) $$$' src/Facets/AcrossFacetPackedV3.sol

# Check if there are any explicit upgrade or migration notes
rg -A 5 -B 5 "upgrade.*[Aa]cross|migration.*[Aa]cross" .

Length of output: 376

---

Script:

#!/bin/bash
# Examine facet implementations directly
echo "=== AcrossFacetV3 Content ==="
cat src/Facets/AcrossFacetV3.sol | head -n 50

echo -e "\n=== AcrossFacetPackedV3 Content ==="
cat src/Facets/AcrossFacetPackedV3.sol | head -n 50

# Look for documentation or comments about upgrades
rg -l "SPDX-License" src/Facets/AcrossFacet*.sol | xargs grep -A 10 "\/\*\*\|\/\/"

Length of output: 73699

---

67-70: Verify integration with ReceiverAcrossV3.

The new AcrossFacetV3 will likely interact with ReceiverAcrossV3 in the Periphery section. Please ensure that the facet and receiver versions are compatible.

Run this script to verify the integration:

Also applies to: 82-82

✅ Verification successful

✓ Version compatibility confirmed between AcrossFacetV3 and ReceiverAcrossV3

Both components are at version 1.1.0 and are designed to work together for cross-chain swaps and message passing via AcrossV3.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for version compatibility between AcrossFacetV3 and ReceiverAcrossV3

# Search for version dependencies and interface requirements
ast-grep --pattern 'interface $$$AcrossV3$$$'

# Check for any integration tests between the facet and receiver
rg -l 'AcrossFacetV3.*ReceiverAcrossV3|ReceiverAcrossV3.*AcrossFacetV3' test/

Length of output: 127

---

Script:

#!/bin/bash
# Find all files containing AcrossFacetV3
echo "=== Files containing AcrossFacetV3 ==="
rg -l "AcrossFacetV3"

echo -e "\n=== Searching for version declarations ==="
rg "version|Version" -A 2 -B 2 $(rg -l "AcrossFacetV3")

echo -e "\n=== Looking for integration patterns ==="
# Search for any Receiver or Across related patterns
rg "(?i)(receiver|across)" -A 3 -B 3 $(rg -l "AcrossFacetV3")

Length of output: 96079

---

Script:

#!/bin/bash
# Search for ReceiverAcrossV3 in the codebase
echo "=== Files containing ReceiverAcrossV3 ==="
rg -l "ReceiverAcrossV3"

echo -e "\n=== Searching for Receiver interfaces or contracts ==="
ast-grep --pattern 'interface $$$Receiver$$$' 
ast-grep --pattern 'contract $$$Receiver$$$'

echo -e "\n=== Looking for integration tests ==="
rg -A 3 -B 3 "ReceiverAcrossV3" test/

Length of output: 7517

---

Script:

#!/bin/bash
# Check version information in ReceiverAcrossV3
echo "=== ReceiverAcrossV3 Version Info ==="
rg "version|Version" -A 2 -B 2 src/Periphery/ReceiverAcrossV3.sol

echo -e "\n=== Checking integration between AcrossFacetV3 and ReceiverAcrossV3 ==="
rg -A 5 -B 5 "AcrossFacetV3.*ReceiverAcrossV3|ReceiverAcrossV3.*AcrossFacetV3" src/

Length of output: 657

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lifi-action-bot]

Test Coverage Report

Line Coverage: 78.66% (2238 / 2845 lines)
Function Coverage: 84.71% ( 388 / 458 functions)
Branch Coverage: 39.60% ( 221 / 558 branches)
Test coverage (78.66%) is above min threshold (76%). Check passed.

[lifi-action-bot]

Test Coverage Report

Line Coverage: 78.66% (2238 / 2845 lines)
Function Coverage: 84.71% ( 388 / 458 functions)
Branch Coverage: 39.60% ( 221 / 558 branches)
Test coverage (78.66%) is above min threshold (76%). Check passed.