Update zksync deploy script naming #942
Conversation
|
Warning Rate limit exceeded@0xDEnYO has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 50 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
script/deploy/deploySingleContract.sh(1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
script/deploy/deploySingleContract.sh
[error] 121-121: Did you forget the 'then' for this 'elif'?
(SC1049)
[error] 121-121: Couldn't parse this elif clause. Fix to allow more checks.
(SC1073)
[error] 123-123: Unexpected keyword/token. Fix any mentioned problems and try again.
(SC1072)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: enforce-min-test-coverage
- GitHub Check: run-unit-tests
Test Coverage ReportLine Coverage: 78.66% (2238 / 2845 lines) |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
script/deploy/deploySingleContract.sh(2 hunks)script/scriptMaster.sh(1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
script/deploy/deploySingleContract.sh
[warning] 126-126: The surrounding quotes actually unquote this. Remove or escape them.
(SC2027)
[warning] 126-126: The surrounding quotes actually unquote this. Remove or escape them.
(SC2027)
[warning] 126-126: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A"B"C"?
(SC2140)
[warning] 128-128: The surrounding quotes actually unquote this. Remove or escape them.
(SC2027)
[warning] 128-128: The surrounding quotes actually unquote this. Remove or escape them.
(SC2027)
[warning] 128-128: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A"B"C"?
(SC2140)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: analyze
- GitHub Check: generate-tag
🔇 Additional comments (5)
script/deploy/deploySingleContract.sh (2)
97-98: LGTM!The code correctly updates the deploy script directory for zksync network.
102-108: LGTM!The code properly handles script selection based on network type, using the correct file extension filtering.
script/scriptMaster.sh (3)
135-139: LGTM!The code correctly updates the deploy script directory and ensures foundry-zksync is installed before proceeding.
140-145: LGTM!The code properly handles script selection based on network type, using the correct file extension filtering.
146-146: LGTM!The code correctly extracts the contract name from the script name.
…ync-deploy-script-naming-lf-11177
0xDEnYO
changed the title
…ync-deploy-script-naming-lf-11177
…com:lifinance/contracts into update-zksync-deploy-script-naming-lf-11177
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
script/deploy/deploySingleContract.sh(2 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
script/deploy/deploySingleContract.sh
[warning] 107-107: Declare and assign separately to avoid masking return values.
(SC2155)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: enforce-min-test-coverage
- GitHub Check: run-unit-tests
- GitHub Check: analyze
- GitHub Check: generate-tag
🔇 Additional comments (3)
script/deploy/deploySingleContract.sh (3)
93-94: LGTM! Good separation of concerns.The introduction of
FILE_EXTENSIONvariable improves maintainability by centralizing the extension management.
99-101: LGTM! Clear network-specific handling.The zksync-specific directory and file extension updates are well-organized and clearly documented.
113-115: LGTM! Clean path construction.The script path construction using proper shell parameter expansion is clear and secure.
Which Jira task belongs to this PR?
https://lifi.atlassian.net/browse/LF-11177
Why did I implement it this way?
to prevent having files in the same repo with the same name (but different content)
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)