-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add config flag to disable precompilation for scriptMaster #962
Conversation
WalkthroughThe pull request introduces two new configuration variables in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
script/config.example.sh (2)
101-102
: Consider exporting the WHITELIST_PERIPHERY variable.The variable is likely used by other deployment scripts. To ensure proper visibility across the deployment pipeline, consider adding the
export
keyword.-WHITELIST_PERIPHERY="FeeCollector,LiFuelFeeCollector,TokenWrapper,LiFiDEXAggregator" +export WHITELIST_PERIPHERY="FeeCollector,LiFuelFeeCollector,TokenWrapper,LiFiDEXAggregator"🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 102-102: WHITELIST_PERIPHERY appears unused. Verify use (or export if used externally).
(SC2034)
104-105
: Consider exporting the COMPILE_ON_STARTUP variable.The variable controls compilation behavior in scriptMaster.sh. To ensure proper visibility, consider adding the
export
keyword.-COMPILE_ON_STARTUP=false +export COMPILE_ON_STARTUP=false🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 105-105: COMPILE_ON_STARTUP appears unused. Verify use (or export if used externally).
(SC2034)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
script/config.example.sh
(1 hunks)script/scriptMaster.sh
(2 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
script/config.example.sh
[warning] 102-102: WHITELIST_PERIPHERY appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 105-105: COMPILE_ON_STARTUP appears unused. Verify use (or export if used externally).
(SC2034)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: enforce-min-test-coverage
- GitHub Check: run-unit-tests
- GitHub Check: run-unit-tests
- GitHub Check: enforce-min-test-coverage
- GitHub Check: generate-tag
- GitHub Check: analyze
🔇 Additional comments (1)
script/scriptMaster.sh (1)
46-48
: LGTM! The conditional compilation is properly implemented.The implementation correctly checks the COMPILE_ON_STARTUP flag before running forge build, which aligns with the configuration changes.
Test Coverage ReportLine Coverage: 78.66% (2238 / 2845 lines) |
Which Jira task belongs to this PR?
Why did I implement it this way?
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)