Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git actions to send messages to Slack instead of Discord #972

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

0xDEnYO
Copy link
Contributor

@0xDEnYO 0xDEnYO commented Feb 4, 2025

Which Jira task belongs to this PR?

Why did I implement it this way?

Due to the recent move from Discord to Slack we need to update our git actions that send messages (reminderss / warnings) to our channels.
The Git secrets have been updated accordingly.

image

Checklist before requesting a review

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

Walkthrough

This pull request updates several GitHub Actions workflows by replacing Discord notifications with Slack notifications. The changes include renaming notification jobs/steps, swapping out the Discord action for the Slack GitHub Action (slackapi/[email protected]), and modifying parameters and environment variables to meet Slack’s webhook and payload requirements.

Changes

Files Change Summary
.github/workflows/diamondEmergencyPause.yml
.github/workflows/networkSecretsChecker.yml
.github/workflows/updateScriptConfigReminder.yml
Replaced Discord notification steps with Slack notifications to the SC-general channel. Updated step/job names (e.g., from "Send Discord message" to "Send Reminder to Slack SC-general Channel"), swapped action from Ilshidur/[email protected] to slackapi/[email protected], adjusted parameters (e.g., replacing args with payload or other Slack-specific parameters), and changed environment variables from DISCORD_WEBHOOK to SLACK_WEBHOOK_SC_GENERAL.
.github/workflows/unreviewedPRReminder.yml Replaced the Discord notification step for unreviewed PR alerts with a Slack notification. Renamed the job to "Send Reminder to Slack PR Review Channel", updated the action from Ilshidur/[email protected] to slackapi/[email protected], modified parameters (from args to payload), and updated the environment variable from DISCORD_WEBHOOK to SLACK_WEBHOOK_SC_REVIEW.

Possibly related PRs

Suggested reviewers

  • ezynda3
  • mirooon
  • maxklenk

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e2f24f and f57b1b5.

📒 Files selected for processing (1)
  • .github/workflows/diamondEmergencyPause.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: run-unit-tests
  • GitHub Check: enforce-min-test-coverage
  • GitHub Check: generate-tag
🔇 Additional comments (1)
.github/workflows/diamondEmergencyPause.yml (1)

90-97: Slack Notification Step Configuration: Verify Payload and Secret Usage
This step correctly replaces the Discord notification with Slack by using slackapi/[email protected] and referencing the updated Slack secret (SLACK_WEBHOOK_SC_GENERAL). Please ensure that the payload format (a YAML block with a text field) complies with the latest Slack webhook API requirements and that the webhook type (incoming-webhook) is correct for your use case.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lifi-action-bot lifi-action-bot marked this pull request as draft February 4, 2025 04:03
@0xDEnYO 0xDEnYO marked this pull request as ready for review February 4, 2025 04:10
@lifi-action-bot
Copy link
Collaborator

Test Coverage Report

Line Coverage: 78.66% (2238 / 2845 lines)
Function Coverage: 84.71% ( 388 / 458 functions)
Branch Coverage: 39.60% ( 221 / 558 branches)
Test coverage (78.66%) is above min threshold (76%). Check passed.

mirooon
mirooon previously approved these changes Feb 4, 2025
Copy link
Contributor

@mirooon mirooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj!

@0xDEnYO 0xDEnYO enabled auto-merge (squash) February 5, 2025 01:44
@0xDEnYO 0xDEnYO dismissed mirooon’s stale review February 5, 2025 10:50

need to re-trigger git actions

mirooon
mirooon previously approved these changes Feb 5, 2025
@0xDEnYO 0xDEnYO dismissed mirooon’s stale review February 5, 2025 10:53

Johann was not a member of the security reviewer group. This is fixed now. One last time to re-trigger the git actions

@0xDEnYO 0xDEnYO merged commit 0f63e33 into main Feb 5, 2025
18 checks passed
@0xDEnYO 0xDEnYO deleted the update-git-actions-for-slack branch February 5, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants