Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cosmos-kit #197

Merged
merged 2 commits into from
Jan 10, 2025
Merged

chore: bump cosmos-kit #197

merged 2 commits into from
Jan 10, 2025

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Jan 9, 2025

The Station wallet was removed from the default wallets.

The feather.js workaround is not needed anymore; it was fixed in cosmos-kit

Summary by CodeRabbit

  • Dependencies

    • Updated versions of several Cosmos-related packages:
      • @cosmos-kit/cosmos-extension-metamask to ^0.12.3
      • @cosmos-kit/react to 2.21.2
      • @cosmos-kit/web3auth to ^2.14.3
      • cosmos-kit to 2.23.4
  • Wallet Configuration

    • Removed 'station' wallet provider from available wallets
    • Updated wallet display logic to exclude 'Station' from the browser options

The `station` wallet was removed from the default wallets by cosmos-kit
@fmorency fmorency requested a review from chalabi2 January 9, 2025 15:37
@fmorency fmorency self-assigned this Jan 9, 2025
Copy link
Contributor

coderabbitai bot commented Jan 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves updates to the package.json file and modifications to the _app.tsx and WalletList.tsx files. The changes primarily focus on updating dependency versions for several Cosmos-related packages and removing a specific package resolution. In the application's main component, the wallet providers configuration has been adjusted, removing the 'station' wallet from the available options, while the filtering logic in the WalletList component has also been updated to exclude the 'Station' wallet from the displayed options.

Changes

File Change Summary
package.json - Removed resolution for **/@hexxagon/feather.js
- Updated dependency versions:
@cosmos-kit/cosmos-extension-metamask: ^0.12.2^0.12.3
@cosmos-kit/react: 2.21.12.21.2
@cosmos-kit/web3auth: ^2.14.2^2.14.3
cosmos-kit: 2.23.12.23.4
pages/_app.tsx - Removed 'station' wallet from combinedWallets array
- Now includes only 'keplr', 'cosmostation', 'leap', and 'ledger' wallets
components/react/views/WalletList.tsx - Updated filtering logic to exclude 'Station' wallet from the displayed options

Possibly related PRs

  • feat: enable ledger #143: Updates to WalletList component to include Ledger wallet, relevant to wallet provider changes.
  • fix: bun lock #170: Related to the removal of the resolution for @hexxagon/feather.js, indicating a connection in dependency management.

Suggested labels

enhancement

Poem

🐰 Hop, hop, through dependencies light,
Wallets dancing, versions taking flight!
Station waves goodbye, new code takes the stage,
Cosmos kit evolves, turning a fresh page!
Dependency dance, a rabbit's delight! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aff3b79 and d63a2bd.

📒 Files selected for processing (1)
  • components/react/views/WalletList.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40e206c and aff3b79.

⛔ Files ignored due to path filters (1)
  • bun.lockb is excluded by !**/bun.lockb
📒 Files selected for processing (2)
  • package.json (2 hunks)
  • pages/_app.tsx (1 hunks)
🔇 Additional comments (2)
package.json (2)

30-30: LGTM: Removal of feather.js resolution

The removal of the feather.js resolution aligns with the PR objectives, as the workaround is no longer necessary.


36-38: Verify latest stable versions of cosmos-kit packages

The package updates appear to be minor version bumps, which should maintain backward compatibility.

Let's verify these are the latest stable versions:

Also applies to: 56-56

✅ Verification successful

All cosmos-kit packages are at latest stable versions

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check latest versions of cosmos-kit packages
echo "Checking latest versions from npm registry..."

for pkg in "@cosmos-kit/cosmos-extension-metamask" "@cosmos-kit/react" "@cosmos-kit/web3auth" "cosmos-kit"; do
    echo "Package: $pkg"
    curl -s "https://registry.npmjs.org/$pkg" | jq -r '.["dist-tags"].latest'
done

Length of output: 1212

pages/_app.tsx Show resolved Hide resolved
Copy link
Collaborator

@chalabi2 chalabi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we remove station, looks good to merge

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.26%. Comparing base (40e206c) to head (d63a2bd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
components/react/views/WalletList.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   54.26%   54.26%           
=======================================
  Files         153      153           
  Lines       15988    15988           
=======================================
  Hits         8676     8676           
  Misses       7312     7312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency merged commit 9c24306 into liftedinit:main Jan 10, 2025
3 of 4 checks passed
@fmorency fmorency deleted the bump-cosmos-kit branch January 10, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants