-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch VSS, Expose build_with_vss* methods in bindings. #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G8XSU
changed the title
Expose build_with_vss_store & build_with_vss_store_with_fixed_headers in bindings.
Expose build_with_vss* methods in bindings.
Oct 15, 2024
G8XSU
force-pushed
the
vss-bindings
branch
2 times, most recently
from
October 15, 2024 18:53
fe89347
to
66bdf17
Compare
G8XSU
changed the title
Expose build_with_vss* methods in bindings.
Launch VSS, Expose build_with_vss* methods in bindings.
Oct 15, 2024
G8XSU
force-pushed
the
vss-bindings
branch
2 times, most recently
from
October 15, 2024 23:41
1f0a68a
to
6afd993
Compare
tnull
reviewed
Oct 16, 2024
G8XSU
force-pushed
the
vss-bindings
branch
2 times, most recently
from
October 17, 2024 00:10
8c94253
to
3a9c604
Compare
CI will fail until rebased on top of #379 |
G8XSU
force-pushed
the
vss-bindings
branch
2 times, most recently
from
October 17, 2024 05:27
4fdddd3
to
368bf60
Compare
Rebased on top #379 |
tnull
reviewed
Oct 17, 2024
tnull
reviewed
Oct 17, 2024
Needs a rebase now that #369 landed. |
Feel free to squash the fixup. |
Squashed. |
tnull
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #369