fix: incremental and full scans are performed correctly #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
approved these changes
Oct 18, 2024
tnull
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Ugh, thank you for catching this.
In my understanding this bug would lead to the first sync attempt after an upgrade always failing, and subsequent syncs doing full_scans, ie, have us not apply the efficiency optimization but in essence rather follow the pre-0.4 syncing approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're performing incremental scans when we should be doing full scans, and vice versa.