Add LSPS2 service-side support #420
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-12-add-lsps2-service-support
branch
2 times, most recently
from
1cca737 to
cd2795d
Compare
Previously, we decided to continue parsing any fields if we failed to parse a known (i.e., `lightning` or `lno`) parameter failed to parse. This however just hides the error and is a bit anti-idiomatic even though allowing to use *some* URI fields even in the face of incompatible formats for others. Here we therefore opt to fail parsing the URI if any field fails.
.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.
We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.
We add the logic required to send `create_order` requests and check on their status.
We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.
Previously, we named internal fields/APIs `lspsX_service` as us being the client was implied. Since we're about to also add service-side functionalities, such naming would start to get confusing. We hence rename them to follow a `lspsX_client` scheme, and will add the service-side APIs using the `service` terminology.
.. and while we're at it we move the VSS child key indexes to constants.
We add the capability to configure LSPS2 service mode in `Builder` and `LiquiditySourceBuilder`.
.. and forward it to our `LiquditySource`.
.. to align with other event handling variants: First log, then act, then emit event if everything went okay.
.. so far with dummy values, we'll have to discuss how the API should look like.
tnull
force-pushed
the
2024-12-add-lsps2-service-support
branch
from
cd2795d to
dfdef1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #418.
WIP