Update BDK to 1.0.0 and LDK to 0.1.0 #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
5 times, most recently
from
cac705d to
ef4caef
Compare
.. and updates to `Cargo.toml`
.. for now by igoring it. Will properly address them in a follow-up
.. we pin `rustls` for now to make CI pass, but mid-term we want to figure out a new MSRV target to bump to.
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
2 times, most recently
from
5cbac77 to
aa745c6
Compare
Previously, we decided to continue parsing any fields if we failed to parse a known (i.e., `lightning` or `lno`) parameter failed to parse. This however just hides the error and is a bit anti-idiomatic even though allowing to use *some* URI fields even in the face of incompatible formats for others. Here we therefore opt to fail parsing the URI if any field fails.
We should drop this commit once lightningdevkit/rust-lightning#3505 got in.
tnull
force-pushed
the
2025-01-upgrade-bdk-ldk
branch
from
aa745c6 to
115104c
Compare
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upgrade LDK and BDK to the latest releases.