Fix documentation. #125
Open
Fix documentation. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
reviewed
Nov 20, 2023
There was a problem hiding this comment.
First commit looks good, have yet to have a closer look at the second one.
Could you provide a PR description and adjust the title to reflect that it doesn't include just a documentation fix? Also, is the second commit related or should it live in an entirely separate PR?
| channelMonitorsSerialized: serializedChannelMonitors, | ||
| networkGraph: NetworkGraphArgument.instance(networkGraph), | ||
| filter: filter, | ||
| params: cmcParams | ||
| ) | ||
|
|
||
| let channelManager = channelManagerConstructor.channelManager |
There was a problem hiding this comment.
While we're here, should we mention the optional fields (in particular the scorer params) below. Users recently seemed unaware how to set them.
|
Eh, I'll split this PR up into two parts. When I pushed the second commit I thought the doc PR had already been merged, and didn't bother pushing to a new remote branch. It should be separate. |
arik-so
force-pushed
the
arik/2023/11/doc_fix
branch
from
cef957a to
b0a7101
Compare
tnull
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.