Add debug implementations for scoring parameters #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amackillop
changed the title
Derives Debug for ProbabilisticScoringFeeParameters and ProbabiliticScoringDecayParameters
amackillop
force-pushed
the
amackillop/2024-12-30/add-debug-to-scorer-params
branch
from
8abc549 to
48ceefd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3511 +/- ##
==========================================
- Coverage 88.32% 88.27% -0.05%
==========================================
Files 149 149
Lines 112912 112921 +9
Branches 112912 112921 +9
==========================================
- Hits 99731 99683 -48
- Misses 10694 10746 +52
- Partials 2487 2492 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use custom scoring parameters in LDK Node but the Config requires
Debugimplementations for its fields. My plan is to add a method to the NodeBuilder to set the parameters in the configuration and use them on startup instead of the defaults if set.