Fix package splitting logic #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scanning confirmed transactions for spends that conflict with our existing packages, we should continue scanning after detecting the first conflicting package since a transaction can conflict with multiple packages. This ensures that we remove *all* inputs from our packages that have already been spent by the counterparty so that valid claim transactions are generated. Fixes lightningdevkit#3537.
wpaulino
approved these changes
Jan 14, 2025
TheBlueMatt
approved these changes
Jan 15, 2025
| // counterparty, even when the counterparty claims HTLCs from multiple packages in a single | ||
| // transaction. | ||
| // | ||
| // This is a regression test for https://github.com/lightningdevkit/rust-lightning/issues/3537. |
There was a problem hiding this comment.
nit: prefer to just write out the issue in the code. Eventually we may move off of github so easier to keep it all in one place.
Merged
|
Backported in #3536. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scanning confirmed transactions for spends that conflict with our existing packages, we should continue scanning after detecting the first conflicting package since a transaction can conflict with multiple packages.
This ensures that we remove all inputs from our packages that have already been spent by the counterparty so that valid claim transactions are generated.
Fixes #3537.