StaticAddr: separate swapserverrpc commits #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
commented
Nov 19, 2024
hieblmi
force-pushed
the
separate-swapserverrpc-commits
branch
from
f3f89ea to
7292031
Compare
|
Closing this PR since tests wouldn't pass if we chose to only separate the rpcs. |
bhandras
approved these changes
Dec 12, 2024
hieblmi
force-pushed
the
separate-swapserverrpc-commits
branch
from
7292031 to
46ab894
Compare
sputn1ck
approved these changes
Dec 12, 2024
This commit adds a new notification to the proto, which is used by the server to request signatures for a deposit of a static loop in.
hieblmi
force-pushed
the
separate-swapserverrpc-commits
branch
from
46ab894 to
d0e484a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we merge the swapserverrpc changes.