-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: fix lnwallet.ErrDoubleSpend
#8887
Merged
yyforyongyu
merged 6 commits into
lightningnetwork:master
from
yyforyongyu:fix-err-match
Jul 8, 2024
+165
−99
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1d40c55
gomod: update `btcwallet` to include RPC errors
yyforyongyu e0a506a
multi: use `chain.MapRPCErr` instead of `rpcclient.MapRPCErr`
yyforyongyu ddf46f4
multi: update RPC error import path
yyforyongyu 8f4bcd0
lnwallet: fix `ErrDoubleSpend`
yyforyongyu 26a365e
docs: update release notes
yyforyongyu e27a656
docs: add release notes for `0.18.3`
yyforyongyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
# Release Notes | ||
- [Bug Fixes](#bug-fixes) | ||
- [New Features](#new-features) | ||
- [Functional Enhancements](#functional-enhancements) | ||
- [RPC Additions](#rpc-additions) | ||
- [lncli Additions](#lncli-additions) | ||
- [Improvements](#improvements) | ||
- [Functional Updates](#functional-updates) | ||
- [RPC Updates](#rpc-updates) | ||
- [lncli Updates](#lncli-updates) | ||
- [Breaking Changes](#breaking-changes) | ||
- [Performance Improvements](#performance-improvements) | ||
- [Technical and Architectural Updates](#technical-and-architectural-updates) | ||
- [BOLT Spec Updates](#bolt-spec-updates) | ||
- [Testing](#testing) | ||
- [Database](#database) | ||
- [Code Health](#code-health) | ||
- [Tooling and Documentation](#tooling-and-documentation) | ||
|
||
# Bug Fixes | ||
|
||
* `closedchannels` now [successfully reports](https://github.com/lightningnetwork/lnd/pull/8800) | ||
settled balances even if the delivery address is set to an address that | ||
LND does not control. | ||
|
||
* [SendPaymentV2](https://github.com/lightningnetwork/lnd/pull/8734) now cancels | ||
the background payment loop if the user cancels the stream context. | ||
|
||
* [Fixed a bug](https://github.com/lightningnetwork/lnd/pull/8822) that caused | ||
LND to read the config only partially and continued with the startup. | ||
|
||
# New Features | ||
## Functional Enhancements | ||
## RPC Additions | ||
|
||
* The [SendPaymentRequest](https://github.com/lightningnetwork/lnd/pull/8734) | ||
message receives a new flag `cancelable` which indicates if the payment loop | ||
is cancelable. The cancellation can either occur manually by cancelling the | ||
send payment stream context, or automatically at the end of the timeout period | ||
if the user provided `timeout_seconds`. | ||
|
||
## lncli Additions | ||
|
||
* [Added](https://github.com/lightningnetwork/lnd/pull/8491) the `cltv_expiry` | ||
argument to `addinvoice` and `addholdinvoice`, allowing users to set the | ||
`min_final_cltv_expiry_delta`. | ||
|
||
* The [`lncli wallet estimatefeerate`](https://github.com/lightningnetwork/lnd/pull/8730) | ||
command returns the fee rate estimate for on-chain transactions in sat/kw and | ||
sat/vb to achieve a given confirmation target. | ||
|
||
# Improvements | ||
## Functional Updates | ||
## RPC Updates | ||
|
||
* [`xImportMissionControl`](https://github.com/lightningnetwork/lnd/pull/8779) | ||
now accepts `0` failure amounts. | ||
|
||
* [`ChanInfoRequest`](https://github.com/lightningnetwork/lnd/pull/8813) | ||
adds support for channel points. | ||
|
||
## lncli Updates | ||
|
||
* [`importmc`](https://github.com/lightningnetwork/lnd/pull/8779) now accepts | ||
`0` failure amounts. | ||
|
||
* [`getchaninfo`](https://github.com/lightningnetwork/lnd/pull/8813) now accepts | ||
a channel outpoint besides a channel id. | ||
|
||
* [Fixed](https://github.com/lightningnetwork/lnd/pull/8823) how we parse the | ||
`--amp` flag when sending a payment specifying the payment request. | ||
|
||
## Code Health | ||
## Breaking Changes | ||
## Performance Improvements | ||
|
||
* Mission Control Store [improved performance during DB | ||
flushing](https://github.com/lightningnetwork/lnd/pull/8549) stage. | ||
|
||
# Technical and Architectural Updates | ||
## BOLT Spec Updates | ||
|
||
* Start assuming that all hops used during path-finding and route construction | ||
[support the TLV onion | ||
format](https://github.com/lightningnetwork/lnd/pull/8791). | ||
|
||
* Allow channel fundee to send a [minimum confirmation depth of | ||
0](https://github.com/lightningnetwork/lnd/pull/8796) for a non-zero-conf | ||
channel. We will still wait for the channel to have at least one confirmation | ||
and so the main change here is that we don't error out for such a case. | ||
|
||
## Testing | ||
## Database | ||
## Code Health | ||
## Tooling and Documentation | ||
|
||
# Contributors (Alphabetical Order) | ||
|
||
* Andras Banki-Horvath | ||
* Bufo | ||
* Elle Mouton | ||
* Matheus Degiovani | ||
* Oliver Gugger | ||
* Slyghtning | ||
* Yong Yu |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not map the error here like before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use the method
MapRPCErr
we need to access the chain backend, which cannot be used here. Instead, we pass the already mapped error tobroadcastErrorMapper
, and access the method viacs.MapRPCErr
above.