Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route blinding [4/4]: update MC on receive from blinded path #9004

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

route blinding [4/4]: update MC on receive from blinded path #9004

wants to merge 12 commits into from

Conversation

ellemouton
Copy link
Collaborator

@ellemouton ellemouton commented Aug 14, 2024 •
edited
Loading

In this PR, we start persisting invoice blinded path info. Then, when we receive a payment from a blinded path, we can use this info to report success to mission control. This will then ensure that future selected routes for blinded paths are of better quality.

Fixes #8991
(Addresses part 4 of #6690)

Depends on:

TODO:

  • write an itest.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 14, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ellemouton ellemouton linked an issue Aug 14, 2024 that may be closed by this pull request
Route Blinding: Report successful receives to Mission Control #8991
Open
@ellemouton ellemouton changed the title route blinding: update MC on receive from blinded path route blinding [4/4]: update MC on receive from blinded path Aug 14, 2024
@ellemouton ellemouton force-pushed the rb-updateMC branch 3 times, most recently from 97fba78 to b9d6a9c Compare August 15, 2024 07:53
@saubyk saubyk added this to the v0.19.0 milestone Aug 15, 2024
@ellemouton ellemouton added the size/mega large, significant context needed, over 1000 lines label Aug 22, 2024
@ellemouton
go.mod: update lightning-onion dep
c84d0b4
@ellemouton
blindedpath: introduce PathInfo struct
0c91e9d 
This new struct holds the zpay32.BlindedPaymentPath along with other
useful info about the constructed path like:
1) the session key: which we can later use (as the path constructor) to
   decrypt the blobs we sent to each blinded hop in the path.
2) the last ephemeral pub key which we can use to uniquely identify this
   path.
@ellemouton
blindedpath: add test to demo unblinding data as the sender
7fb998d
@ellemouton
routing+channeldb: export and move MCRoute
af22149 
Move it to the models package to avoid import cycles later on.
@ellemouton
routing: update MissionControl API to take MCRoute
690380f 
instead of route.Route. This will be useful for a later commit when we
only have access to MCRoute and want to report success to MC.
@ellemouton
multi: start setting BlindedPathsInfo on Invoice struct
df60d66 
Note that then new field is not yet persisted.
@ellemouton
channeldb: serialise blinded path info for bbolt invoice
952da0a
@ellemouton
go.mod+invoices: update sql_store to use new blinded path tables
0980809
@ellemouton
invoices: add test to persist and retrieve invoice with blinded path
18c4155
@ellemouton
multi: report blinded path receives to Mission Control
59f8bab 
in the new "blinded-paths" namespace.
@ellemouton
multi: query probabilities for blinded paths from new MC namespace
262b95c 
Start querying blinded path probabilites from the new MC namespace where
the results of successful blinded path receives will be written to.
@ellemouton
docs: add release note
c5f2e11
@ellemouton ellemouton changed the base branch from elle-namespacedMC to master October 2, 2024 08:20
@saubyk saubyk modified the milestones: v0.19.0, v0.20.0 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ellemouton ellemouton

Labels
blinded paths size/mega large, significant context needed, over 1000 lines
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.

Route Blinding: Report successful receives to Mission Control
2 participants
@ellemouton @saubyk