week4 tune

lihungte96 · Mar 11, 2019 · 90e4114 · 90e4114
1 parent d6eb9fb
commit 90e4114
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 49 deletions.
diff --git a/junit/README.md b/junit/README.md
@@ -15,19 +15,13 @@ $ make
 
 ## syllabus
 ### week3
-[onlyTest](onlyTest)
-
+#### [onlyTest](onlyTest)
 Only JUint test
-
-[testCode](testCode)
-
+#### [testCode](testCode)
 Simple assert
 
 ### week4
-[beforeAfter](beforeAfter)
-
+#### [beforeAfter](beforeAfter)
 Show execution path of before and after annotation
-
-[Stack](Stack)
-
+#### [Stack](Stack)
 Use stack example show why use before and after annotation
diff --git a/junit/beforeAfter/Makefile b/junit/beforeAfter/Makefile
@@ -2,7 +2,7 @@ all: compile
 
 compile:
 	mkdir -p bin
-	javac testcase/TestJunit.java testcase/TestRunner.java -d bin
+	javac testcase/TestBeforeAfter.java testcase/TestRunner.java -d bin
 
 test:
 	cd bin ; java TestRunner

diff --git a/junit/beforeAfter/testcase/TestJunit.java b/junit/beforeAfter/testcase/TestJunit.java
diff --git a/junit/beforeAfter/testcase/TestRunner.java b/junit/beforeAfter/testcase/TestRunner.java
@@ -4,7 +4,7 @@
 
 public class TestRunner {
    public static void main(String[] args) {
-      Result result = JUnitCore.runClasses(TestJunit.class);
+      Result result = JUnitCore.runClasses(TestBeforeAfter.class);
       for (Failure failure : result.getFailures()) {
          System.out.println(failure.toString());
       }

diff --git a/junit/stack/src/Stack.java b/junit/stack/src/Stack.java
@@ -12,7 +12,7 @@ public Stack() {
         size = 0;
     }
 
-    public int size(){
+    public int size() {
         return this.size;
     }
 
@@ -26,7 +26,7 @@ public void push(Object obj) {
 
     public Object pop() throws Exception {
         if (head == null) {
-            throw new Exception();
+            throw new Exception("Pop an empty stack");
         }
         Object tmp = head.data;
         head = head.next;

diff --git a/junit/stack/testcase/TestStack.java b/junit/stack/testcase/TestStack.java
@@ -12,15 +12,19 @@ public static void beforeClass() {
 
     @Before
     public void before() {
+        // initial some node in stack structure
         stack.push(3);
         stack.push(2);
     }
 
     @After
     public void after() throws Exception {
+        // clean all node in stack
         while (stack.size() != 0) {
             stack.pop();
         }
+        // try to create some exception
+	//stack.pop();
     }
 
     @AfterClass