Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dingTalk Robot message support #431

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: dingTalk Robot message support #431

wants to merge 13 commits into from

Conversation

blackstrip
Copy link

Added

DingTalk Robot provider support

@blackstrip blackstrip mentioned this pull request Mar 9, 2022
Open
liiight
liiight requested changes Mar 9, 2022
View reviewed changes
Copy link
Owner

@liiight liiight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! If possible, please provide me with an access_token I can use for continued testing. you can send me a DM on twitter or email to python.notifiers at gmail dot com

notifiers/providers/dingtalk.py Outdated Show resolved Hide resolved
notifiers/providers/dingtalk.py Outdated Show resolved Hide resolved
notifiers/providers/dingtalk.py Outdated Show resolved Hide resolved
@blackstrip blackstrip requested a review from liiight March 10, 2022 07:51
liiight
liiight requested changes Mar 10, 2022
View reviewed changes
Copy link
Owner

@liiight liiight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you need to have an attribute named message, so you may need to map it to the relevant text attribute correlating to the correct msg_type

notifiers/providers/dingtalk.py Outdated Show resolved Hide resolved
notifiers/providers/dingtalk.py Outdated Show resolved Hide resolved
notifiers/providers/dingtalk.py Outdated Show resolved Hide resolved
@blackstrip blackstrip requested a review from liiight March 11, 2022 07:17
liiight
liiight requested changes Mar 11, 2022
View reviewed changes
Copy link
Owner

@liiight liiight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change requested. Also, if you can supply me with access_token that will be used for integration testing that will be great. If not, that's ok too :)

notifiers/providers/dingtalk.py Show resolved Hide resolved
@blackstrip blackstrip requested a review from liiight March 11, 2022 08:10
@blackstrip blackstrip requested a review from liiight March 13, 2022 15:05
@liiight
Copy link
Owner

liiight commented Mar 16, 2022

I saw you sent me the token, thanks for that. I need to figure out why the tests didn't run and to take care of some infrastructure stuff before merging this.

I have some stuff going on these days but I promise to take care of this asap and not let this get stale.

Thank you so much for contributing!

@liiight
Copy link
Owner

liiight commented Jul 12, 2022

@blackstrip I apologize for not completing this, hopefully will have the capacity to do this soon

@liiight liiight added this to the 1.4.0 milestone Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liiight liiight Awaiting requested review from liiight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@blackstrip @liiight