Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use original filename with prefix as output filename #11

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

williamchong
Copy link
Member

@williamchong williamchong commented Sep 20, 2021

Hacky way to solve #10

@edmondyu
Copy link
Contributor

It seems to miss one important and related issue. If the purpose of this change is for supporting concurrent processes, the processes must be run with different wallet address or else code 32 error will occur.
Differentiating the output filenames cannot solve the problem completely, but yet is an improvement for better readability.

@williamchong
Copy link
Member Author

Your issue is too specific then, I dont think this can work without major restructuring
A very simple hack would be just copy and paste many instance of this repo with different config
And to step even further back, if the problem you concern is the speed of upload, we dont event need multiple instances, we just need non-blocking sync broadcast with result callback
So I guess when opening an issue you dont want to go too specific into technical details, if you just have a issue with a story in mind

@williamchong williamchong merged commit 3588aaa into likecoin:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants