Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Get 100 items for listing tags #2045

Merged
merged 1 commit into from
Feb 6, 2025
Merged

🔧 Get 100 items for listing tags #2045

merged 1 commit into from
Feb 6, 2025

Conversation

williamchong
Copy link
Member

No description provided.

@williamchong williamchong requested review from nwingt, AuroraHuang22 and a team February 4, 2025 10:48
nwingt
nwingt reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@nwingt nwingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just changing the default here

liker-land/src/util/api/index.js

Line 615 in 7c2e76e

{ offset, t = BOOKSTORE_CMS_CACHE_RESET_TIMESTAMP, limit = 30 } = {}

@williamchong
Copy link
Member Author

how about just changing the default here

liker-land/src/util/api/index.js

Line 615 in 7c2e76e

{ offset, t = BOOKSTORE_CMS_CACHE_RESET_TIMESTAMP, limit = 30 } = {}

i don't know, what was the reason behind setting 30 in the pagination PR?
If it is just the landing needs 100, other tags could keep using 30

@williamchong williamchong merged commit 58c8490 into likecoin:develop Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwingt nwingt nwingt left review comments

@AuroraHuang22 AuroraHuang22 Awaiting requested review from AuroraHuang22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamchong @nwingt