version bugs for Mac #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a small bug with the previous code |
MCKevmeister
suggested changes
Feb 20, 2023
| @@ -76,7 +76,7 @@ function encrypt(password) { | |||
| return callback(); | |||
| } | |||
|
|
|||
| var encryptedBody = cryptojs.AES.encrypt(marked(originalBody), password), | |||
| var encryptedBody = cryptojs.AES.encrypt(marked.parse(originalBody), password), | |||
There was a problem hiding this comment.
This is the only thing that needs to be in the pull request. You have included many .md files for your specific project, and exposed your password as well
| @@ -90,7 +90,7 @@ function encrypt(password) { | |||
|
|
|||
| gulp.task('firewall:encrypt', () => { | |||
| return gulp.src('_protected/*.*') | |||
| .pipe(encrypt('password')) | |||
| .pipe(encrypt('kismet2357')) | |||
|
Thanks !!!
Best wishes
…On Tue, Feb 21, 2023 at 4:59 AM Mark Christison ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In gulpfile.js
<#13 (comment)>
:
> @@ -76,7 +76,7 @@ function encrypt(password) {
return callback();
}
- var encryptedBody = cryptojs.AES.encrypt(marked(originalBody), password),
+ var encryptedBody = cryptojs.AES.encrypt(marked.parse(originalBody), password),
This is the only thing that needs to be in the pull request. You have
included many .md files for your specific project, and exposed your
password as well
------------------------------
In gulpfile.js
<#13 (comment)>
:
> @@ -90,7 +90,7 @@ function encrypt(password) {
gulp.task('firewall:encrypt', () => {
return gulp.src('_protected/*.*')
- .pipe(encrypt('password'))
+ .pipe(encrypt('kismet2357'))
Whoops, exposed your password
—
Reply to this email directly, view it on GitHub
<#13 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGG7AMC4FNQ4LBUSTADDQDTWYPLJZANCNFSM5PDRLD7Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
**********************************************************
〒606-8585 京都市左京区松ケ崎橋上町
京都工芸繊維大学
繊維学系
(Phd, Dr.
Division of Advanced Fibro-Science
Kyoto Institute of Technology,
Matsugasaki, Sakyo-Ku, Kyoto, 606-8585, JAPAN)
张 辉耀 (ZHANG HUIYAO)
TEL 080-8716-6955 E-mail: ***@***.***
************************************************************
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.