Improve hd_monitor code quality

Remove useless print, parameter and format strings according to review of ros#334
limaanto · May 28, 2024 · a7e68ac · a7e68ac
1 parent 8eba67b
commit a7e68ac
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/diagnostic_common_diagnostics/diagnostic_common_diagnostics/hd_monitor.py b/diagnostic_common_diagnostics/diagnostic_common_diagnostics/hd_monitor.py
@@ -90,7 +90,7 @@ def callback_config(self, params: List[rclpy.Parameter]):
     def check_disk_usage(self, diag: DiagnosticStatus) -> DiagnosticStatus:
         diag.level = DiagnosticStatus.OK
 
-        total, used, free = disk_usage(self._path)
+        total, _, free = disk_usage(self._path)
         percent = free / total
 
         if percent > self._free_percent_low:
@@ -102,14 +102,13 @@ def check_disk_usage(self, diag: DiagnosticStatus) -> DiagnosticStatus:
 
         total_Go = total // (1024*1024)
         diag.values.extend([
-            KeyValue(key=f'Name', value=self._path),
-            KeyValue(key=f'Status', value=DICT_STATUS[diag.level]),
-            KeyValue(key=f'Total (Go)', value=str(total_Go)),
-            KeyValue(key=f'Available (%)', value=str(round(percent, 2))),
+            KeyValue(key='Name', value=self._path),
+            KeyValue(key='Status', value=DICT_STATUS[diag.level]),
+            KeyValue(key='Total (Go)', value=str(total_Go)),
+            KeyValue(key='Available (%)', value=str(round(percent, 2))),
         ])
 
         diag.message = DICT_USAGE[diag.level]
-        print(diag)
         return diag