Upgrade Flutter v3.24.5 #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why we need to close this PR?--
Sent from Twake Mail
Vào ngày thg 1 9, 2025 3:48 CH, từ Dat Dang ***@***.***>
Closed #103.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
Because it wasn't needed |
|
Actually it is needed. |
dab246
reviewed
Jan 10, 2025
Comment on lines
-31
to
+49
| 'total': const UnsignedIntNullableConverter().toJson(instance.total), | ||
| 'limit': const UnsignedIntNullableConverter().toJson(instance.limit), | ||
| 'total': _$JsonConverterToJson<int, UnsignedInt>( | ||
| instance.total, const UnsignedIntConverter().toJson), | ||
| 'limit': _$JsonConverterToJson<int, UnsignedInt>( | ||
| instance.limit, const UnsignedIntConverter().toJson), | ||
| }; | ||
|
|
||
| Value? _$JsonConverterFromJson<Json, Value>( | ||
| Object? json, | ||
| Value? Function(Json json) fromJson, | ||
| ) => | ||
| json == null ? null : fromJson(json as Json); | ||
|
|
||
| Json? _$JsonConverterToJson<Json, Value>( | ||
| Value? value, | ||
| Json? Function(Value value) toJson, | ||
| ) => | ||
| value == null ? null : toJson(value); |
There was a problem hiding this comment.
Why do we have to write an additional function to check for nullability, even though there is a separate converter for nullable?
There was a problem hiding this comment.
The code in *.g.dart is automatically generated by build_runner
dab246
reviewed
Jan 10, 2025
Comment on lines
-30
to
+47
| 'total': const UnsignedIntNullableConverter().toJson(instance.total), | ||
| 'limit': const UnsignedIntNullableConverter().toJson(instance.limit), | ||
| 'total': _$JsonConverterToJson<int, UnsignedInt>( | ||
| instance.total, const UnsignedIntConverter().toJson), | ||
| 'limit': _$JsonConverterToJson<int, UnsignedInt>( | ||
| instance.limit, const UnsignedIntConverter().toJson), | ||
| }; | ||
|
|
||
| Value? _$JsonConverterFromJson<Json, Value>( | ||
| Object? json, | ||
| Value? Function(Json json) fromJson, | ||
| ) => | ||
| json == null ? null : fromJson(json as Json); | ||
|
|
||
| Json? _$JsonConverterToJson<Json, Value>( | ||
| Value? value, | ||
| Json? Function(Value value) toJson, | ||
| ) => | ||
| value == null ? null : toJson(value); |
There was a problem hiding this comment.
Why do we have to write an additional function to check for nullability, even though there is a separate converter for nullable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.