Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-971 added explanation for contact permission #972

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

KhaledNjim
Copy link
Collaborator

Issue

Solution

  • added dialog to explain the use of contacts permission before requesting it

Demo

LA-971.mp4

@KhaledNjim KhaledNjim self-assigned this Dec 19, 2024
@KhaledNjim KhaledNjim requested a review from hoangdat December 19, 2024 19:10
@hoangdat
Copy link
Member

hi @KhaledNjim, we should handle it for permission in image/video or files also

@KhaledNjim
Copy link
Collaborator Author

hi @KhaledNjim, we should handle it for permission in image/video or files also

Updated, added explanation before requesting permission for image/video microphone and phone state.
for files permission is not requested

permission_linshare.mp4

@hoangdat
Copy link
Member

  • you should add specific explanation for these 2 options also (don't forget if it uses in other spaces(shared space, received share)
Screenshot_2024-12-30-05-34-42-670_com linagora android linshare

@hoangdat
Copy link
Member

hoangdat commented Dec 29, 2024

  • you should mention clearly which function to make user understand about your permission request for what. I suggest: To continue to recording video .....

@hoangdat
Copy link
Member

hoangdat commented Dec 29, 2024

permission explanation still display after user accepted permission

DoD:

  • should not display after user granted permission
Screenrecorder-2024-12-30-05-37-45-561.mp4

@KhaledNjim
Copy link
Collaborator Author

  • you should add specific explanation for these 2 options also (don't forget if it uses in other spaces(shared space, received share)
Screenshot_2024-12-30-05-34-42-670_com linagora android linshare

In those cases, no permissions are requested

@KhaledNjim
Copy link
Collaborator Author

  • you should mention clearly which function to make user understand about your permission request for what. I suggest: To continue to recording video .....

Updated

image

@hoangdat
Copy link
Member

hoangdat commented Jan 6, 2025

In those cases, no permissions are requested

No, these still need request permission, so please add the explanation for these too.

IMG_0187

@KhaledNjim
Copy link
Collaborator Author

In those cases, no permissions are requested

No, these still need request permission, so please add the explanation for these too.

IMG_0187

Updated, this permission is only requested on api 32 and lower
image

@KhaledNjim KhaledNjim force-pushed the playstore_evaluation branch from 7f963bd to edf72ed Compare January 7, 2025 09:15
@hoangdat hoangdat merged commit 534c568 into master Jan 7, 2025
4 checks passed
@hoangdat hoangdat deleted the playstore_evaluation branch January 7, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants